Update request @ Time Formats page
| From: | Mick Harner | Date: | Thu, 05 Nov 2015 01:19:05 +0000 |
| Subject: | Update request @ Time Formats page | ||
| Groups: | php.webmaster | ||
| Request: | Send a blank email to php-webmaster+get-24278@lists.php.net to get a copy of this message | ||
Dear PHP.net Webmasters,
@ http://php.net/manual/en/datetime.formats.time.php
hh "0"?[1-9] | "1"[0-2] "04", "7", "12"
HH [01][0-9] | "2"[0-4] "04", "7", "19"
Please consider updating the regexp and examples to:
hh 0?[1-9] | 1[0-2] "4", "07", "12"
HH [01][0-9] | 2[0-4]
"07", "12", "24"
My reasoning:
* ?The double quotes and spaces in the regexp are unnecessary. (only a matter of personal
preference)
* In the examples for hh, I ordered the examples in accordance with the literal meaning of the ?
=> zero or one occurrence of the 0. (only a matter of personal preference)
* In the examples for HH, there must not be "7"; it must be prefixed by a
"0". (a matter of incorrect content)
Sincerely,
mickmackusa