com web/php: logo.php: Check if QUERY_STRING is set bef ore using it: images/logo.php
| From: | Christoph Michael Becker | Date: | Tue, 06 Sep 2016 19:04:05 +0000 |
| Subject: | com web/php: logo.php: Check if QUERY_STRING is set bef ore using it: images/logo.php | ||
| Groups: | php.webmaster | ||
| Request: | Send a blank email to php-webmaster+get-25191@lists.php.net to get a copy of this message | ||
Commit: 64c35d8825bf01c778c080d9bc086b31dfa3d80b
Author: Kevin Israel <pleasestand@live.com> Tue, 6 Sep 2016 15:01:30 -0400
Parents: 98660d0163f45ee423cfebfbf78badd8315b2c36
Branches: master
Link: http://git.php.net/?p=web/php.git;a=commitdiff;h=64c35d8825bf01c778c080d9bc086b31dfa3d80b
Log:
logo.php: Check if QUERY_STRING is set before using it
Fixes a PHP Notice introduced in 0df71ff798c722f3.
Changed paths:
M images/logo.php
Diff:
diff --git a/images/logo.php b/images/logo.php
index f20fd07..55cf28e 100644
--- a/images/logo.php
+++ b/images/logo.php
@@ -70,13 +70,14 @@ function serve_compressed_if_available($logo) {
readfile($logo);
}
-switch ($_SERVER['QUERY_STRING']) {
- case 'QA':
- case 'qa':
- $logo = './logos/qa.jpg';
- break;
- default:
- $logo = './logos/php-logo.svg';
+$logo = './logos/php-logo.svg';
+if (isset($_SERVER['QUERY_STRING'])) {
+ switch ($_SERVER['QUERY_STRING']) {
+ case 'QA':
+ case 'qa':
+ $logo = './logos/qa.jpg';
+ break;
+ }
}
// xmas season, december and the first week of January