Patches for web-master
| From: | Maciej Sobaczewski | Date: | Wed, 23 Nov 2016 07:39:40 +0000 |
| Subject: | Patches for web-master | ||
| Groups: | php.webmaster | ||
| Request: | Send a blank email to php-webmaster+get-25353@lists.php.net to get a copy of this message | ||
Hi .
Altought I don't have commit karma for web-master, I'd like to suggest merging a few patches I've prepared, focusing on notes management section.
http://sobak.pl/pliki/web-master-patches/
You can view them online: https://github.com/salathe/php-web-master/compare/master...Sobak:sobak - diff is based on Peter's unofficial Github mirror. Also, please ignore first commit regaring .gitignore file (I didn't include it in *.patch files).
I know that master.php.net is rather crucial part of infrastructure so I tried to keep diffs minimal and test changes locally (but I don't have production database, obviously, so tests were based on my sample).
Those patches allow for:
- paginating search results for notes instead of showing only first 20
- searching notes within a manual section (with wildcard support, please take a look at first screenshot below)
Apart from that, there are two interface changes which should make it a little bit cleaner.
Screenshots:
http://sobak.pl/img/screenshots/omEiEmC1.png
http://sobak.pl/img/screenshots/vd9M2ez6.png
I would be glad if someone with commit karma for web-master could review and eventually merge my changes. I've planned to do some more refactoring but those are most important for me, because I moderate notes alot recently, trying to clean things up.
Cheers and thanks in advance,
Maciej.