com web/rmtools: actually, we barely need these checks: include/Branch.php

From: Date: Thu, 23 Mar 2017 18:58:21 +0000
Subject: com web/rmtools: actually, we barely need these checks: include/Branch.php
Groups: php.webmaster 
Request: Send a blank email to php-webmaster+get-25871@lists.php.net to get a copy of this message
Commit: ae0d70a0c7f22d1efb0b016b8381fc5926b3aca6 Author: Anatol Belski <ab@php.net> Thu, 23 Mar 2017 19:58:21 +0100 Parents: 5faf4beed73d79f73509a87dd97442c9c2faeef3 Branches: master Link: http://git.php.net/?p=web/rmtools.git;a=commitdiff;h=ae0d70a0c7f22d1efb0b016b8381fc5926b3aca6 Log: actually, we barely need these checks leave some, though, but for vc all the crt is passed from the config anyway Changed paths: M include/Branch.php Diff: diff --git a/include/Branch.php b/include/Branch.php index 890a0de..2a20638 100644 --- a/include/Branch.php +++ b/include/Branch.php @@ -214,25 +214,12 @@ class Branch { $compiler = strtolower($build['compiler']); switch ($compiler) { - /* XXX scan the configs for compatible compiler list*/ - case 'vc15': - case 'vc14': - case 'vc12': - case 'vc11': - case 'vc9': - case 'vc6': - $build = new BuildVC($this, $build_name); - break; case 'icc': case 'gcc': case 'clang': + throw new \Exception("$compiler not supported yet. Not implemented."); default: - if ($compiler) { - throw new \Exception("$compiler not supported yet. Not implemented."); - } else { - throw new \Exception("Unknown or unsupported compiler passed."); - } - break; + $build = new BuildVC($this, $build_name); } return $build;

« previous php.webmaster (#25871) next »