com web/rmtools: yet one piece on vc15 support, and improve the exception: include/Branch.php
| From: | Anatol Belski | Date: | Thu, 23 Mar 2017 18:25:15 +0000 |
| Subject: | com web/rmtools: yet one piece on vc15 support, and improve the exception: include/Branch.php | ||
| Groups: | php.webmaster | ||
| Request: | Send a blank email to php-webmaster+get-25876@lists.php.net to get a copy of this message | ||
Commit: 5faf4beed73d79f73509a87dd97442c9c2faeef3
Author: Anatol Belski <ab@php.net> Thu, 23 Mar 2017 19:25:15 +0100
Parents: d43e6bd6f6dd0bda14a79a4ed0b337c4e854d934
Branches: master
Link: http://git.php.net/?p=web/rmtools.git;a=commitdiff;h=5faf4beed73d79f73509a87dd97442c9c2faeef3
Log:
yet one piece on vc15 support, and improve the exception
Changed paths:
M include/Branch.php
Diff:
diff --git a/include/Branch.php b/include/Branch.php
index 412c51f..890a0de 100644
--- a/include/Branch.php
+++ b/include/Branch.php
@@ -215,6 +215,7 @@ class Branch {
$compiler = strtolower($build['compiler']);
switch ($compiler) {
/* XXX scan the configs for compatible compiler list*/
+ case 'vc15':
case 'vc14':
case 'vc12':
case 'vc11':
@@ -225,7 +226,12 @@ class Branch {
case 'icc':
case 'gcc':
case 'clang':
- throw new \Exception("$compiler not supported yet. Not implemented");
+ default:
+ if ($compiler) {
+ throw new \Exception("$compiler not supported yet. Not implemented.");
+ } else {
+ throw new \Exception("Unknown or unsupported compiler passed.");
+ }
break;
}