com web/rmtools: just some comments: client/include/PickleBuildVC.php client/include/PickleExt.php client/script/pickle.php

Commit: fe002faa73d545f9ceb7a4bde700d8177eeb36df Author: Anatol Belski <ab@php.net> Mon, 4 May 2015 22:47:08 +0200 Parents: 8b465d6f479cfd90a3ea46715e2ebb720b719764 Branches: master pecl_legacy Link: http://git.php.net/?p=web/rmtools.git;a=commitdiff;h=fe002faa73d545f9ceb7a4bde700d8177eeb36df Log: just some comments Changed paths: M client/include/PickleBuildVC.php M client/include/PickleExt.php M client/script/pickle.php Diff: diff --git a/client/include/PickleBuildVC.php b/client/include/PickleBuildVC.php index 6a41470..d4256e5 100644 --- a/client/include/PickleBuildVC.php +++ b/client/include/PickleBuildVC.php @@ -121,6 +121,7 @@ class PickleBuildVC } + /* XXX read the configure options from the extconfig, create the options file to feed pickle */ public function build(PickleExt $ext) { $cmd = $this->pickle_cmd; diff --git a/client/include/PickleExt.php b/client/include/PickleExt.php index cd8033f..7e3920f 100644 --- a/client/include/PickleExt.php +++ b/client/include/PickleExt.php @@ -54,6 +54,11 @@ class PickleExt { return $this->pkg_uri; } + + public function cleanup() + { + // pass + } } diff --git a/client/script/pickle.php b/client/script/pickle.php index 25d5372..558977e 100644 --- a/client/script/pickle.php +++ b/client/script/pickle.php @@ -55,10 +55,11 @@ foreach ($builds as $build_name) { continue; } + /* XXX check zipball path before saying this */ echo "Pickle build successful, packaging logs" . PHP_EOL; + // add the deps license to the pickle archive ... or should pickle do that? //$build->packLogs(); - //$build->archive(); /* upload logs and builds */ /* notify pickle */