Re: com web/wiki: Fix another incompatible method signature: dokuwiki/lib/plugins/doodle/syntax.php

2018-01-21 16:04 GMT+01:00 Peter Cowburn <petercowburn@gmail.com>: > > > On 21 January 2018 at 10:49, Niklas Keller <kelunik@php.net> wrote: > >> Commit: b57ed02dc53405fdffea72be28e213de2e771b8e >> Author: Niklas Keller <me@kelunik.com> Sun, 21 Jan 2018 >> 11:49:19 +0100 >> Parents: 5f359399895def1d979e6337d8f9482218783829 >> Branches: master >> >> Link: >> http://git.php.net/?p=web/wiki.git;a=commitdiff;h=b57ed02dc >> 53405fdffea72be28e213de2e771b8e >> >> Log: >> Fix another incompatible method signature >> >> Changed paths: >> M dokuwiki/lib/plugins/doodle/syntax.php >> >> >> Diff: >> diff --git a/dokuwiki/lib/plugins/doodle/syntax.php >> b/dokuwiki/lib/plugins/doodle/syntax.php >> index 39b1f84..7b338e2 100755 >> --- a/dokuwiki/lib/plugins/doodle/syntax.php >> +++ b/dokuwiki/lib/plugins/doodle/syntax.php >> @@ -193,7 +193,7 @@ class syntax_plugin_doodle extends >> DokuWiki_Syntax_Plugin >> * add new vote if user just submitted one and >> * create output xHTML from template >> */ >> - function render($mode, &$renderer, $data) { >> + function render($mode, Doku_Renderer $renderer, $data) { >> > > It looks like the patch file in systems/doodle-voting.diff is drifting out > of sync, could you update that when making changes? > Should probably delete it instead. I think there won't be any updates anymore to the version we're using. A new patch can be added once we migrate to a newer major version of the doodle plugin. Thoughts? Regards, Niklas