com web/bugs: Replace DIRECTORY_SEPARATOR with slash st ring: include/classes/bug_patchtracker.php
| From: | Peter Kokot | Date: | Sun, 02 Dec 2018 23:04:33 +0000 |
| Subject: | com web/bugs: Replace DIRECTORY_SEPARATOR with slash st ring: include/classes/bug_patchtracker.php | ||
| Groups: | php.webmaster | ||
| Request: | Send a blank email to php-webmaster+get-27474@lists.php.net to get a copy of this message | ||
Commit: 32466d710928c42d841e519a61cd8743c26cfea4
Author: Peter Kokot <peterkokot@gmail.com> Mon, 3 Dec 2018 00:04:33 +0100
Parents: 017e87d850745e11b68228f1a11e5bb46543494e
Branches: master
Link: http://git.php.net/?p=web/bugs.git;a=commitdiff;h=32466d710928c42d841e519a61cd8743c26cfea4
Log:
Replace DIRECTORY_SEPARATOR with slash string
The constant DIRECTORY_SEPARATOR is in the used cases not needed to work
ok on Windows. PHP functions in these cases can handle normal slash
fine and this patch simplifies this a bit.
Changed paths:
M include/classes/bug_patchtracker.php
Diff:
diff --git a/include/classes/bug_patchtracker.php b/include/classes/bug_patchtracker.php
index 2ec645c..18c01d2 100644
--- a/include/classes/bug_patchtracker.php
+++ b/include/classes/bug_patchtracker.php
@@ -111,8 +111,7 @@ class Bug_Patchtracker
*/
public function getPatchFullpath($bugid, $name, $revision)
{
- return $this->patchDir($bugid, $name) .
- DIRECTORY_SEPARATOR . $this->getPatchFileName($revision);
+ return $this->patchDir($bugid, $name).'/'.$this->getPatchFileName($revision);
}
/**
@@ -241,8 +240,8 @@ class Bug_Patchtracker
$this->dbh->prepare('DELETE FROM bugdb_patchtracker
WHERE bugdb_id = ? and patch = ? and revision = ?')->execute(
[$bugid, $name, $revision]);
- @unlink($this->patchDir($bugid, $name) . DIRECTORY_SEPARATOR .
- $this->getPatchFileName($revision));
+
+ @unlink($this->patchDir($bugid, $name).'/'.$this->getPatchFileName($revision));
}
/**