com web/bugs: Use closures over create_function(): in clude/classes/bug_diff_renderer.php

Commit: 3c4fa66c4cae0d09c4cbecc305e99de217ecae49 Author: Kalle Sommer Nielsen <kalle@php.net> Sat, 15 Dec 2018 22:17:49 +0100 Parents: bae5fa6c4428956efd618bf69038f724875b7de5 Branches: master Link: http://git.php.net/?p=web/bugs.git;a=commitdiff;h=3c4fa66c4cae0d09c4cbecc305e99de217ecae49 Log: Use closures over create_function() Changed paths: M include/classes/bug_diff_renderer.php Diff: diff --git a/include/classes/bug_diff_renderer.php b/include/classes/bug_diff_renderer.php index 9fb0b3c..0071109 100644 --- a/include/classes/bug_diff_renderer.php +++ b/include/classes/bug_diff_renderer.php @@ -37,19 +37,22 @@ class Bug_Diff_Renderer extends Text_Diff_Renderer public function _added($lines) { - array_walk($lines, create_function('&$a,$b', '$a=htmlspecialchars($a);')); + self::escapeHTML($lines); + return '<span class="newdiff"> ' . implode("</span>\n<span class='newdiff'> ", $lines) . '</span>'; } public function _context($lines) { - array_walk($lines, create_function('&$a,$b', '$a=htmlspecialchars($a);')); + self::escapeHTML($lines); + return "\n" . parent::_context($lines); } public function _deleted($lines) { - array_walk($lines, create_function('&$a,$b', '$a=htmlspecialchars($a);')); + self::escapeHTML($lines); + return '<span class="olddiff"> ' . implode("</span>\n<span class='olddiff'> ", $lines) . '</span>'; } @@ -62,4 +65,12 @@ class Bug_Diff_Renderer extends Text_Diff_Renderer { return parent::render($this->diff); } + + protected static function escapeHTML(&$lines) + { + array_walk($lines, function(&$a, $b) + { + $a = htmlspecialchars($a); + }); + } }