Re: com web/php: Fix dates on last month's releases.: include/releases.inc

On 10.01.2019 at 21:05, Adam Harvey wrote: > Commit: ca17ae50be45c8d0e3a22e93d07a8b54bd645051 > Author: Adam Harvey <aharvey@php.net> Thu, 10 Jan 2019 12:05:57 -0800 > Parents: 3a3c0d223c50d89a5e68399f9c8c514407e2ee67 > Branches: master > > Link: > http://git.php.net/?p=web/php.git;a=commitdiff;h=ca17ae50be45c8d0e3a22e93d07a8b54bd645051 > > Log: > Fix dates on last month's releases. > > Changed paths: > M include/releases.inc > > > Diff: > diff --git a/include/releases.inc b/include/releases.inc > index 1666de4..91d9f98 100644 > --- a/include/releases.inc > +++ b/include/releases.inc > @@ -32,7 +32,7 @@ $OLDRELEASES = array ( > 'date' => '06 Dec 2018', > ), > ), > - 'date' => '10 Jan 2019', > + 'date' => '06 Dec 2018', > 'museum' => false, > ), > '7.3.0' => > @@ -65,7 +65,7 @@ $OLDRELEASES = array ( > 'date' => '06 Dec 2018', > ), > ), > - 'date' => '10 Jan 2019', > + 'date' => '06 Dec 2018', > 'museum' => false, > ), > '7.2.13' => Thanks! It seems to me that <https://github.com/php/web-php/blob/d3cbe13d1956a984f25fe593dd1454d4b1e7046b/bin/bumpRelease#L28> can't really work. Even if <https://github.com/php/web-php/blob/d3cbe13d1956a984f25fe593dd1454d4b1e7046b/include/version.inc#L205> had been updated, following releases of other 7.x branches would have the wrong date. Shouldn't the minor_version parameter of bumpReleases be mandatory? -- Christoph M. Becker