com web/windows: First include, then release lock: include/listing.php
| From: | Anatol Belski | Date: | Wed, 06 Feb 2019 04:19:20 +0000 |
| Subject: | com web/windows: First include, then release lock: include/listing.php | ||
| Groups: | php.webmaster | ||
| Request: | Send a blank email to php-webmaster+get-27773@lists.php.net to get a copy of this message | ||
Commit: 1aab433e8668f8b737f2ad011c00ebf2b61fd58d
Author: Anatol Belski <ab@php.net> Tue, 5 Feb 2019 20:19:20 -0800
Parents: f4687db1594b518d25a23ab91067af9c384eaecc
Branches: master
Link: http://git.php.net/?p=web/windows.git;a=commitdiff;h=1aab433e8668f8b737f2ad011c00ebf2b61fd58d
Log:
First include, then release lock
Changed paths:
M include/listing.php
Diff:
diff --git a/include/listing.php b/include/listing.php
index 08625b0..b061eac 100644
--- a/include/listing.php
+++ b/include/listing.php
@@ -90,9 +90,9 @@ function generate_listing($path, $nmode) {
flock($lck, LOCK_EX);
if (file_exists($path . '/cache.info')) {
+ include $path . '/cache.info';
flock($lck, LOCK_UN);
fclose($lck);
- include $path . '/cache.info';
return $releases;
}