Bug #78060 [Com]: Large image sizes don't show properly
| From: | petk@php.net | Date: | Fri, 24 May 2019 09:50:39 +0000 |
| Subject: | Bug #78060 [Com]: Large image sizes don't show properly | ||
| References: | 1 | Groups: | php.webmaster |
| Request: | Send a blank email to php-webmaster+get-28084@lists.php.net to get a copy of this message | ||
Edit report at https://bugs.php.net/bug.php?id=78060&edit=1
ID: 78060
Comment by: petk@php.net
Reported by: petk@php.net
Summary: Large image sizes don't show properly
Status: Open
Type: Bug
Package: Website problem
PHP Version: Irrelevant
Block user comment: N
Private report: N
New Comment:
@salathe, absolutely. I've only reported few issues I found along. It's up to you and the
rest of the web php people here mainly probably Kalle also what you will do with these reports.
There were more but (not related to this ticket but others) I think that only seeing my name here
causes conflicts now also. I'll just rm -rf todo.txt and move along. Thanks.
Previous Comments:
------------------------------------------------------------------------
[2019-05-24 09:37:25] salathe@php.net
I was just trying to clarify what should be the existing process, and gave a personal opinion; not
to dictate anything. I hope we can have differing thoughts and opinions yet still get a productive
outcome.
------------------------------------------------------------------------
[2019-05-24 09:35:47] cmb@php.net
Well, we could set up a pre-commit hook where the image size would
be checked.
------------------------------------------------------------------------
[2019-05-24 09:30:52] petk@php.net
Ok... :) I think that this is wrong approach, but your call here. I don't merge pull requests
there so I'm sure you'll catch it on time then.
------------------------------------------------------------------------
[2019-05-24 09:27:51] salathe@php.net
This should be being caught when reviewing the Pull Requests. Any PRs with huge images should not
be approved until an appropriately-sized image is used instead.
If a commit doesn't go through the review system and a huge image does added to the repo, then
I would rather it be displayed as huge so we can notice the issue and get the image resized.
------------------------------------------------------------------------
[2019-05-24 08:56:00] petk@php.net
Description:
------------
Leftover from my very long TODO list of bugs for these PHP sites - maybe someone who will be fixing
these sites will have motivation to fix them.
http://php.net/conferences/
^ here if the image size is too big (let's say 1600x800) there should be limit in CSS to scale
such image responsively to a max width.
------------------------------------------------------------------------
--
Edit this bug report at https://bugs.php.net/bug.php?id=78060&edit=1