cvs: php-bugs-web / bug.php lstats.php /include functions.inc resolve.inc

felipe Thu Oct 23 12:02:35 2008 UTC Modified files: /php-bugs-web bug.php lstats.php /php-bugs-web/include functions.inc resolve.inc Log: - Added new status ("To be documented") # When fixing a bug that needs be documented, change the status to 'To be documented' # And then, when documenting it, change the status to Closed. http://cvs.php.net/viewvc.cgi/php-bugs-web/bug.php?r1=1.90&r2=1.91&diff_format=u Index: php-bugs-web/bug.php diff -u php-bugs-web/bug.php:1.90 php-bugs-web/bug.php:1.91 --- php-bugs-web/bug.php:1.90 Thu Oct 16 12:07:14 2008 +++ php-bugs-web/bug.php Thu Oct 23 12:02:34 2008 @@ -179,6 +179,8 @@ if ($in['status'] == 'Bogus' && !in_array($bug['status'], array ('Bogus', 'Closed', 'Duplicate', 'No feedback', 'Wont fix')) && strlen(trim($ncomment)) == 0) { $errors[] = "You must provide a comment when marking a bug 'Bogus'"; + } elseif ($in['status'] == 'To be documented') { + $errors[] = "You must provide a comment to help in the feature/issue documentation"; } elseif ($in['resolve']) { if (!$trytoforce && $RESOLVE_REASONS[$in['resolve']]['status'] == $bug['status']) { $errors[] = "The bug is already marked '" . $bug['status'] . "'. (Submit again to ignore this.)"; @@ -187,7 +189,9 @@ if ($in['status'] == $bug['status']) { $in['status'] = $RESOLVE_REASONS[$in['resolve']]['status']; } - if (isset($FIX_VARIATIONS[$in['resolve']][$bug['bug_type']])) { + if ($in['status'] == 'Closed' && $bug['status'] == 'To be documented') { + $resolve_message = $FIX_VARIATIONS['fixedcvs']['Documentation problem']; + } elseif (isset($FIX_VARIATIONS[$in['resolve']][$bug['bug_type']])) { $resolve_message = $FIX_VARIATIONS[$in['resolve']][$bug['bug_type']]; } else { $resolve_message = $RESOLVE_REASONS[$in['resolve']]['message']; http://cvs.php.net/viewvc.cgi/php-bugs-web/lstats.php?r1=1.22&r2=1.23&diff_format=u Index: php-bugs-web/lstats.php diff -u php-bugs-web/lstats.php:1.22 php-bugs-web/lstats.php:1.23 --- php-bugs-web/lstats.php:1.22 Tue Jul 15 22:10:13 2008 +++ php-bugs-web/lstats.php Thu Oct 23 12:02:34 2008 @@ -61,7 +61,7 @@ $totals = array(); foreach ($items as $category => $name) { - $count = get_status_count ("status NOT IN('closed', 'bogus', 'duplicate', 'wont fix', 'no feedback')", $category); + $count = get_status_count ("status NOT IN('to be documented', 'closed', 'bogus', 'duplicate', 'wont fix', 'no feedback')", $category); if ($count > 0) { $totals[$category] = $count; } http://cvs.php.net/viewvc.cgi/php-bugs-web/include/functions.inc?r1=1.245&r2=1.246&diff_format=u Index: php-bugs-web/include/functions.inc diff -u php-bugs-web/include/functions.inc:1.245 php-bugs-web/include/functions.inc:1.246 --- php-bugs-web/include/functions.inc:1.245 Fri Oct 10 00:17:01 2008 +++ php-bugs-web/include/functions.inc Thu Oct 23 12:02:34 2008 @@ -95,6 +95,7 @@ "Stale" => 0, "Fresh" => 0, "Bogus" => 2, + "To be documented" => 1, "All" => 0 ); @@ -246,6 +247,7 @@ 'Verified' => 'Ver', 'Suspended' => 'Sus', 'Closed' => 'Csd', + 'To be documented' => 'Tbd' ); $headers[] = array(" ID", $bug['id']); @@ -363,11 +365,19 @@ "X-PHP-Bug: $bug[id]\n". "In-Reply-To: <bug-$bug[id]@bugs.php.net>", "-fbounces-ignored@php.net"); + + $Cc = ''; + if ($in['status'] == 'To be documented' || + ($in['status'] == 'Closed' && $bug['status'] == 'To be documented')) { + $Cc = "Cc: doc-bugs@lists.php.net\n"; + } + # but we go ahead and let the default sender get used for the list @mail($mailto, rinse($subj) . txfield('sdesc'), $dev_text, "From: $from\n". + $Cc. "X-PHP-Bug: $bug[id]\n". "X-PHP-Version: " . stripslashes((($edit != 3) ? $in['php_version'] : $bug['php_version'])) . "\n" . "X-PHP-Category: " . stripslashes((($edit != 3) ? $in['bug_type'] : $bug['bug_type'])) . "\n" . @@ -593,6 +603,9 @@ case "Duplicate": return "#bbbbbb"; break; + case "To be documented": + return "#cdb26e"; + break; default: return "#aaaaaa"; break; http://cvs.php.net/viewvc.cgi/php-bugs-web/include/resolve.inc?r1=1.59&r2=1.60&diff_format=u Index: php-bugs-web/include/resolve.inc diff -u php-bugs-web/include/resolve.inc:1.59 php-bugs-web/include/resolve.inc:1.60 --- php-bugs-web/include/resolve.inc:1.59 Thu Oct 9 11:31:17 2008 +++ php-bugs-web/include/resolve.inc Thu Oct 23 12:02:34 2008 @@ -52,6 +52,20 @@ Thank you for the report, and for helping us make PHP better.', ), + + 'needdocs' => array( + 'status' => 'To be documented', + 'desc' => 'Fixed in CVS and need be documented', + 'message' => +'This bug has been fixed in CVS. + +Snapshots of the sources are packaged every three hours; this change +will be in the next snapshot. You can grab the snapshot at +http://snaps.php.net/. + +Thank you for the report, and for helping us make PHP better.', + ), + 'alreadyfixed' => array( 'status' => 'Closed', 'desc' => 'Fixed in release',