com web/master: Notes: sort out view=notes vs view=note s: manage/user-notes.php
| From: | Maciej Sobaczewski | Date: | Sun, 19 Apr 2020 00:16:43 +0000 |
| Subject: | com web/master: Notes: sort out view=notes vs view=note s: manage/user-notes.php | ||
| Groups: | php.webmaster | ||
| Request: | Send a blank email to php-webmaster+get-28592@lists.php.net to get a copy of this message | ||
Commit: 2b82952b09a105273d140742cd605d7982d5da86
Author: Sobak <msobaczewski@gmail.com> Sun, 19 Apr 2020 02:16:43 +0200
Parents: eb0d668b71abbd10bfb59645fa13b2b94d49573b
Branches: master
Link: http://git.php.net/?p=web/master.git;a=commitdiff;h=2b82952b09a105273d140742cd605d7982d5da86
Log:
Notes: sort out view=notes vs view=notes
It looks like the actual value of view doesn't change anything, only its
presence matters. However, if we are going to ever use that in the
future it's better to have it consistent.
Plus it simply bothered me :)
Changed paths:
M manage/user-notes.php
Diff:
diff --git a/manage/user-notes.php b/manage/user-notes.php
index f32c60e...b28f9b7 100644
--- a/manage/user-notes.php
+++ b/manage/user-notes.php
@@ -380,14 +380,14 @@ if (!$action) {
// Setting type is here only to avoid notice or more conditions.
// It won't cause to show last notes (type=0) as $_REQUEST['keyword']
presence has higher priority.
$type = 0;
- echo "<p><a
href=\"?view=1&page=$page&type=$type$keyword\">Next 10</a>";
+ echo "<p><a
href=\"?view=notes&page=$page&type=$type$keyword\">Next 10</a>";
} elseif (isset($_REQUEST["view"]) && !empty($search_votes)) {
echo "<p>";
if (isset($NextPage) && $NextPage > 1) {
- echo "<a
href=\"?view=1&page=$PrevPage&type=$type{$isSearch}\">< Prev
25</a> ";
+ echo "<a
href=\"?view=notes&page=$PrevPage&type=$type{$isSearch}\">< Prev
25</a> ";
}
if (isset($to) && isset($resultCount) && $to < $resultCount) {
- echo " <a
href=\"?view=1&page=$NextPage&type=$type{$isSearch}\">Next 25
></a>";
+ echo " <a
href=\"?view=notes&page=$NextPage&type=$type{$isSearch}\">Next 25
></a>";
}
echo "</p>";
}