Re: com web/php: Fix Bug #79524: include/langchooser.inc

From: Date: Mon, 04 May 2020 08:09:16 +0000
Subject: Re: com web/php: Fix Bug #79524: include/langchooser.inc
References: 1  Groups: php.webmaster 
Request: Send a blank email to php-webmaster+get-28613@lists.php.net to get a copy of this message
On Mon, 4 May 2020 at 02:00, Sherif Ramadan <googleguy@php.net> wrote: > Commit: 7691b44067db646287064df92ad6bd10718ba9a6 > Author: Sherif Ramadan <googleguy@php.net> Mon, 4 May 2020 > 00:59:21 +0000 > Parents: f6c004c5625ca7cf811e2f0a95b8f3c197f1e14f > Branches: master > > Link: > > http://git.php.net/?p=web/php.git;a=commitdiff;h=7691b44067db646287064df92ad6bd10718ba9a6 > > Log: > Fix Bug #79524 > > Ignore LAST_LANG cookie from now on, because it's stupid. Honor > Accept-Language > headers instead. > Since we're ignoring the LAST_LANG cookie now, we should probably not bother setting it. Also, don't forget to update my.php to properly reflect the new behaviour. > > Bugs: > https://bugs.php.net/79524 > > Changed paths: > M include/langchooser.inc > > > Diff: > diff --git a/include/langchooser.inc b/include/langchooser.inc > index ead85974c..d09b036f2 100644 > --- a/include/langchooser.inc > +++ b/include/langchooser.inc > @@ -92,11 +92,6 @@ function language_choose_code() > language_add(myphpnet_language(), $languages); > } > > - // Put the last selected language in the priority order (if available) > - if (isset($_COOKIE['LAST_LANG'])) { > - language_add($_COOKIE['LAST_LANG'], $languages); > - } > - > // Specified by the user via the browser's Accept Language setting > // Samples: "hu, en-us;q=0.66, en;q=0.33", "hu,en-us;q=0.5" > $browser_langs = array(); $parsed_langs = array(); > > > -- > PHP Webmaster List Mailing List (http://www.php.net/) > To unsubscribe, visit: http://www.php.net/unsub.php > >

« previous php.webmaster (#28613) next »