com web/master: skip Diffie-Hellman ciphers for fetching user notes from master (bug #79663): scripts/update-user-notes
| From: | Peter Cowburn | Date: | Sun, 07 Jun 2020 10:33:13 +0000 |
| Subject: | com web/master: skip Diffie-Hellman ciphers for fetching user notes from master (bug #79663): scripts/update-user-notes | ||
| Groups: | php.webmaster | ||
| Request: | Send a blank email to php-webmaster+get-28664@lists.php.net to get a copy of this message | ||
Commit: fc7ab27cda68f6e1d803dc25ac6b30d8b472969e
Author: Peter Cowburn <salathe@php.net> Sun, 7 Jun 2020 11:32:50 +0100
Parents: f0ad7ed7515d5822f840661d97907717a4c9a92f
Branches: master
Link: http://git.php.net/?p=web/master.git;a=commitdiff;h=fc7ab27cda68f6e1d803dc25ac6b30d8b472969e
Log:
skip Diffie-Hellman ciphers for fetching user notes from master (bug #79663)
Without this, fetching user notes fails on the rsync box with the
OpenSSL error (which is suppressed via the @ operator):
error:141A318A:SSL routines:tls_process_ske_dhe:dh key too small
TODO: likely other scripts need similar treatment until Apache is
upgraded on master.
Bugs:
https://bugs.php.net/79663
Changed paths:
M scripts/update-user-notes
Diff:
diff --git a/scripts/update-user-notes b/scripts/update-user-notes
index 5d46694..451df59 100755
--- a/scripts/update-user-notes
+++ b/scripts/update-user-notes
@@ -27,9 +27,16 @@ if(in_array('https', stream_get_wrappers())) {
/* get user notes */
if($SSL_fopen) {
+ $ctx = stream_context_create([
+ 'ssl' => [
+ 'ciphers' => 'DEFAULT:!DH',
+ ],
+ ]);
$fp = @fopen(
"https://master.php.net/fetch/user-notes.php?token=$token".($since?"&since=$since":""),
- "r"
+ "r",
+ false,
+ $ctx
);
} else {
$url = escapeshellarg("https://master.php..net/fetch/user-notes.php?token=$token".($since?"&since=$since":""));