[web-php][PR #340] - add a top-margin to all elements which get referenced by anchor-urls,…
| From: | noreply@php.net | Date: | Tue, 25 Aug 2020 12:16:24 +0000 |
| Subject: | [web-php][PR #340] - add a top-margin to all elements which get referenced by anchor-urls,… | ||
| Groups: | php.webmaster | ||
| Request: | Send a blank email to php-webmaster+get-28746@lists.php.net to get a copy of this message | ||
You can view the Pull Request on github:
https://github.com/php/web-php/pull/340
Opened By: staabm
Pull Request Description:
… so they are not covered by the fixed header
Repro
- open a url like https://www.php.net/manual/en/opcache.configuration.php#ini.opcache.enable-file-override
without the PRs patch, the anchor to which the browser scrolls to, is hidden behind the fixed header
toolbar
see this picture, in which I temporarily made the header transparent, so you can see what I mean:

with this fix applied, the browser knows that a margin of 60px should be used, so the actual content
is visible to the end user.

After a bit more testing I get the feeling the site is scrolling via javascript to get the same
feature across.
This seem to not work consistently, because sometimes I can get the browser to not scroll into the
correct position. now sure how to reproduce this consistently right now tho.