[web-php][PR #417] - Fix to allow news2html to handle multi-line 'module'
| From: | noreply@php.net | Date: | Wed, 21 Jul 2021 18:29:11 +0000 |
| Subject: | [web-php][PR #417] - Fix to allow news2html to handle multi-line 'module' | ||
| Groups: | php.webmaster | ||
| Request: | Send a blank email to php-webmaster+get-29433@lists.php.net to get a copy of this message | ||
You can view the Pull Request on github:
https://github.com/php/web-php/pull/417
Opened By: mikeschinkel
Pull Request Description:
I am not sure this PR is valid because I only had one set of NEWS files to process. But, maybe it
is:
I needed a NEWS file to test bin/news2html and the only ones in the repo were
/resources/NEWS_5_4_0_*.txt. Unfortunately, those had a few 'entries' that appeared to
have no 'modules' and that caused the script to crash. So I added logic to recognize those
and assign them to the 'Core' module and that allowed the script to work. As part of this,
I unravelled the if..elseif..else logic to be a series of if..continue since the if statements were
all in a loop and no code was run after the if..elseif..else statement.