Bug #53703 [Opn->Wfx]: Cannot upload patches with chars < chr(32)

Edit report at https://bugs.php.net/bug.php?id=53703&edit=1 ID: 53703 Updated by: cmb@php.net Reported by: jthijssen at noxlogic dot nl Summary: Cannot upload patches with chars < chr(32) -Status: Open +Status: Wont fix Type: Bug Package: Website problem Operating System: NA PHP Version: Irrelevant -Assigned To: +Assigned To: cmb Block user comment: N Private report: N New Comment: Even if this is still an issue, I don't think it makes sense to address it, since pull request are much more preferred, and we may actually consider to remove the upload patch facility altogether. Previous Comments: ------------------------------------------------------------------------ [2014-08-05 18:27:51] sobak@php.net The following patch has been added/updated: Patch Name: test-script Revision: 1407263271 URL: https://bugs.php.net/patch-display.php?bug=53703&patch=test-script&revision=1407263271 ------------------------------------------------------------------------ [2011-01-09 21:50:13] jthijssen at noxlogic dot nl Description: ------------ The "add-a-patch" system in the php.net bug tracker will check for mime-types after uploading a patch. When a file has some low ascii-characters, it will not be detected correctly as a plain text file. The upload will not success in that case. There are some files in the php sources that have these low ascii characters present so patches on those files cannot be uploaded correctly. Test script: --------------- The files: ext/standard/tests/strings/strip_tags_variation5.phpt ext/standard/tests/strings/strip_tags_variation8.phpt ext/standard/tests/strings/strip_tags_variation9.phpt have some low ascii characters: ^K and ^L. Because of this, linux' "file" command detect those files "incorrectly": jthijssen@debian-jth:~/php-src-5.3$ file ext/standard/tests/strings/strip_tags_variation5.phpt ext/standard/tests/strings/strip_tags_variation5.phpt: data jthijssen@debian-jth:~/php-src-5.3$ file ext/standard/tests/strings/strip_tags_variation4.phpt ext/standard/tests/strings/strip_tags_variation4.phpt: ASCII C program text Expected result: ---------------- The patch should be added to the bug Actual result: -------------- The bug database reports an incorrect filetype (detected: application/octet-stream) ------------------------------------------------------------------------ -- Edit this bug report at https://bugs.php.net/bug.php?id=53703&edit=1