[web-php] master: No superfluous elseif
| From: | Mathias Reker ⚡️ via GitHub | Date: | Fri, 17 Jun 2022 14:06:22 +0000 |
| Subject: | [web-php] master: No superfluous elseif | ||
| Groups: | php.webmaster | ||
| Request: | Send a blank email to php-webmaster+get-30080@lists.php.net to get a copy of this message | ||
Author: Mathias Reker ⚡️ (MathiasReker)
Committer: GitHub (web-flow)
Pusher: cmb69
Date: 2022-06-17T16:00:47+02:00
Commit: https://github.com/php/web-php/commit/63f1e9d0047ae458ad0b008d8d27795fd88f7ef8
Raw diff: https://github.com/php/web-php/commit/63f1e9d0047ae458ad0b008d8d27795fd88f7ef8.diff
No superfluous elseif
Replaces superfluous elseif with if.
Closes GH-549.
Changed paths:
M manual/vote-note.php
Diff:
diff --git a/manual/vote-note.php b/manual/vote-note.php
index 4831c85d1..787d96b8c 100644
--- a/manual/vote-note.php
+++ b/manual/vote-note.php
@@ -54,7 +54,7 @@
echo json_encode($response);
exit;
}
- elseif (!empty($_REQUEST['id']) && !empty($_REQUEST['page'])
&& ($N = manual_notes_load($_REQUEST['page'])) &&
array_key_exists($_REQUEST['id'], $N) && !empty($_REQUEST['vote'])
&& ($_REQUEST['vote'] === 'up' || $_REQUEST['vote'] ===
'down')) {
+ if (!empty($_REQUEST['id']) && !empty($_REQUEST['page']) &&
($N = manual_notes_load($_REQUEST['page'])) &&
array_key_exists($_REQUEST['id'], $N) && !empty($_REQUEST['vote'])
&& ($_REQUEST['vote'] === 'up' || $_REQUEST['vote'] ===
'down')) {
if (!empty($_POST['challenge']) && !empty($_POST['func']) ||
empty($_POST['arga']) || empty($_POST['argb'])) {
if (!test_answer($_POST['func'], $_POST['arga'],
$_POST['argb'], $_POST['challenge'])) {
$error = "Incorrect answer! Please try again.";