[web-php] master: No alias functions
| From: | Mathias Reker ⚡️ via GitHub | Date: | Fri, 17 Jun 2022 15:19:39 +0000 |
| Subject: | [web-php] master: No alias functions | ||
| Groups: | php.webmaster | ||
| Request: | Send a blank email to php-webmaster+get-30096@lists.php.net to get a copy of this message | ||
Author: Mathias Reker ⚡️ (MathiasReker)
Committer: GitHub (web-flow)
Pusher: cmb69
Date: 2022-06-17T17:14:03+02:00
Commit: https://github.com/php/web-php/commit/89ac76cd81ca5cf2d3b1a979e97b503e22a95c14
Raw diff: https://github.com/php/web-php/commit/89ac76cd81ca5cf2d3b1a979e97b503e22a95c14.diff
No alias functions
Canonical functions shall be used instead of aliases.
Closes GH-530.
Changed paths:
M manual/spam_challenge.php
M mirror-info.php
M my.php
Diff:
diff --git a/manual/spam_challenge.php b/manual/spam_challenge.php
index 8f7710ad3..1dbf94b93 100644
--- a/manual/spam_challenge.php
+++ b/manual/spam_challenge.php
@@ -39,7 +39,7 @@ function print_prefix($name, $a, $b) {
// generate a challenge
function gen_challenge() {
global $challenges, $nums;
- $c = $challenges[rand(0, sizeof($challenges)-1)];
+ $c = $challenges[rand(0, count($challenges)-1)];
$a = rand(0, 9);
$an = $nums[$a];
diff --git a/mirror-info.php b/mirror-info.php
index cee36ffc8..fdec4629f 100644
--- a/mirror-info.php
+++ b/mirror-info.php
@@ -31,7 +31,7 @@ function_exists('hash_file') &&
$exts = implode(',', get_loaded_extensions());
-echo join('|', array(
+echo implode('|', array(
$MYSITE, // 0 : CNAME for mirror as accessed (CC, CC1, etc.)
phpversion(), // 1 : PHP version overview
$LAST_UPDATED, // 2 : Update problems
diff --git a/my.php b/my.php
index 67fd2bdeb..fd0ddc0bf 100644
--- a/my.php
+++ b/my.php
@@ -47,7 +47,7 @@
// Assemble form from collected data
$langpref = "<select name=\"my_lang\">\n" .
- join("", $options) . "</select>\n";
+ implode("", $options) . "</select>\n";
// Save URL shortcut fallback setting
if (isset($_POST['urlsearch'])) {