Re: Coding Standard for https://github.com/php/web-php

On 17.06.2022 at 16:45, Andreas Möller wrote: > As pull requests suggesting coding standard changes have been opened in the past (see > https://github.com/php/web-php/pull/196 > <https://github.com/php/web-php/pull/196>) and more recently > (see https://github.com/php/web-php/pulls/MathiasReker > <https://github.com/php/web-php/pulls/MathiasReker>) there > appears to be some controversy around coding standards. > > As Christoph Becker suggested, it would be best to reach out in the mailing list (see > https://github.com/php/web-php/pull/540#issuecomment-1158931457 > <https://github.com/php/web-php/pull/540#issuecomment-1158931457>). > > Personally, I am not interested in discussions around coding standards. It is a boring topic, > and as long as a coding standard can be enforced with a tool, the best documentation of a coding > standard is the configuration of the tool that enforces the coding standard. > > How do members of the mailing list feel about enforcing a coding standard for > https://github.com/php/web-php > <https://github.com/php/web-php> with a tool? Ugh, sorry, I've totally missed this mail since there have been a lot of mails on that particular day. Others might have missed the mail for the same reasons. Anyhow, I'm very much in favor of establishing a coding standard for web-php (and the other web-* repos). Actually, that should have been done long ago. I'm also in favor of using some tool to enforce that CS, although that might raise the "we don't want to use third-party tools to avoid endorsing any particular tools" argument. I hope we can make an exception in this case, since writing our own CS checker doesn't appear to be reasonable. What do others think about introducing PHP_CodeSniffer[1] or PHP-CS-Fixer[2] with a suitable coding standard, which could be the PER Coding Style[3]. [1] <https://github.com/squizlabs/PHP_CodeSniffer> [2] <https://github.com/FriendsOfPHP/PHP-CS-Fixer> [3] <https://www.php-fig.org/per/coding-style/> -- Christoph M. Becker