[web-php] master: Avoid variable function invocation
| From: | Andreas Möller via GitHub | Date: | Wed, 29 Jun 2022 16:42:40 +0000 |
| Subject: | [web-php] master: Avoid variable function invocation | ||
| Groups: | php.webmaster | ||
| Request: | Send a blank email to php-webmaster+get-30194@lists.php.net to get a copy of this message | ||
Author: Andreas Möller (localheinz)
Committer: GitHub (web-flow)
Pusher: cmb69
Date: 2022-06-29T18:36:38+02:00
Commit: https://github.com/php/web-php/commit/98430dbeb50ced7309a758c10b5d68bb5359bd21
Raw diff: https://github.com/php/web-php/commit/98430dbeb50ced7309a758c10b5d68bb5359bd21.diff
Avoid variable function invocation
Closes GH-586.
Changed paths:
M include/shared-manual.inc
Diff:
diff --git a/include/shared-manual.inc b/include/shared-manual.inc
index 4ed4e86fe..ddc4ef5d5 100644
--- a/include/shared-manual.inc
+++ b/include/shared-manual.inc
@@ -439,7 +439,6 @@ function manual_setup($setup) {
site_header($setup["this"][1] . " - Manual ", $config);
$id = substr($setup['this'][0], 0, -4);
- $language_chooser = 'manual_language_chooser';
$repo = strtolower($config['lang']); // pt_BR etc.
$edit_url = "https://github.com/php/doc-{$repo}";
@@ -452,10 +451,12 @@ function manual_setup($setup) {
}
}
+ $languageChooser = manual_language_chooser($config['lang'],
$config['thispage']);
+
echo <<<PAGE_TOOLS
<div class="page-tools">
<div class="change-language">
- {$language_chooser($config['lang'], $config['thispage'])}
+ {$languageChooser}
</div>
<div class="edit-bug">
<a href="{$edit_url}">Submit a Pull Request</a>