cvs: php-bugs-web / bug.php
| From: | Felipe Pena | Date: | Thu, 06 Nov 2008 12:43:08 +0000 |
| Subject: | cvs: php-bugs-web / bug.php | ||
| Groups: | php.webmaster | ||
| Request: | Send a blank email to php-webmaster+get-3024@lists.php.net to get a copy of this message | ||
felipe Thu Nov 6 12:43:08 2008 UTC
Modified files:
/php-bugs-web bug.php
Log:
Reset the assigned value when changing the status to 'To be documented',
as more probably the developer (which was marked as assigned) won't document
the fix.
http://cvs.php.net/viewvc.cgi/php-bugs-web/bug.php?r1=1.92&r2=1.93&diff_format=u
Index: php-bugs-web/bug.php
diff -u php-bugs-web/bug.php:1.92 php-bugs-web/bug.php:1.93
--- php-bugs-web/bug.php:1.92 Thu Oct 23 20:47:04 2008
+++ php-bugs-web/bug.php Thu Nov 6 12:43:08 2008
@@ -179,8 +179,18 @@
if ($in['status'] == 'Bogus' && !in_array($bug['status'],
array ('Bogus', 'Closed', 'Duplicate', 'No feedback',
'Wont fix'))
&& strlen(trim($ncomment)) == 0) {
$errors[] = "You must provide a comment when marking a bug 'Bogus'";
- } elseif ($in['status'] == 'To be documented' &&
strlen(trim($ncomment)) == 0) {
- $errors[] = "You must provide a comment to help in the feature/issue documentation";
+ } elseif ($in['status'] == 'To be documented') {
+ /* Require explanation */
+ if (strlen(trim($ncomment)) == 0) {
+ $errors[] = "You must provide a comment to help in the feature/issue documentation";
+ } else if ($bug['status'] != 'To be documented' &&
$bug['assign'] == $in['assign']) {
+ /*
+ * Reset the assigned value when changing the status to 'To be documented',
+ * as more probably the developer (which was marked as assigned) won't document
+ * the fix.
+ */
+ $in['assign'] == '';
+ }
} elseif ($in['resolve']) {
if (!$trytoforce && $RESOLVE_REASONS[$in['resolve']]['status'] ==
$bug['status']) {
$errors[] = "The bug is already marked '" . $bug['status'] .
"'. (Submit again to ignore this.)";