[web-php] master: OG meta tags by default (#1027)
| From: | Sergey Panteleev via GitHub | Date: | Sat, 06 Jul 2024 13:04:57 +0000 |
| Subject: | [web-php] master: OG meta tags by default (#1027) | ||
| Groups: | php.webmaster | ||
| Request: | Send a blank email to php-webmaster+get-31806@lists.php.net to get a copy of this message | ||
Author: Sergey Panteleev (saundefined)
Committer: GitHub (web-flow)
Pusher: saundefined
Date: 2024-07-06T16:04:44+03:00
Commit: https://github.com/php/web-php/commit/4cf1d83d32f1f7470788802492c880893f96101b
Raw diff: https://github.com/php/web-php/commit/4cf1d83d32f1f7470788802492c880893f96101b.diff
OG meta tags by default (#1027)
Fix #981
Changed paths:
M include/layout.inc
M index.php
Diff:
diff --git a/include/layout.inc b/include/layout.inc
index c7064ecb82..df947f4550 100644
--- a/include/layout.inc
+++ b/include/layout.inc
@@ -424,6 +424,9 @@ function site_header(string $title = 'Hypertext Preprocessor', array
$config = [
{
global $MYSITE;
+ $meta_image_path = $MYSITE . 'images/meta-image.png';
+ $meta_description = "PHP is a popular general-purpose scripting language that powers
everything from your blog to the most popular websites in the world.";
+
$defaults = [
"lang" => myphpnet_language(),
"current" => "",
@@ -432,6 +435,25 @@ function site_header(string $title = 'Hypertext Preprocessor', array
$config = [
'layout_span' => 9,
"cache" => false,
"headsup" => "",
+ 'meta_tags' => <<<META
+<meta name="Description" content="{$meta_description}" />
+
+<meta name="twitter:card" content="summary_large_image" />
+<meta name="twitter:site" content="@official_php" />
+<meta name="twitter:title" content="PHP: Hypertext Preprocessor" />
+<meta name="twitter:description" content="{$meta_description}" />
+<meta name="twitter:creator" content="@official_php" />
+<meta name="twitter:image:src" content="{$meta_image_path}" />
+
+<meta itemprop="name" content="PHP: Hypertext Preprocessor" />
+<meta itemprop="description" content="$meta_description" />
+<meta itemprop="image" content="{$meta_image_path}" />
+
+<meta property="og:image" content="{$meta_image_path}" />
+<meta property="og:description" content="$meta_description" />
+
+<link href="https://fosstodon.org/@php"
rel="me" />
+META
];
$config = array_merge($defaults, $config);
diff --git a/index.php b/index.php
index 9e889f7880..3e2f74ef0f 100644
--- a/index.php
+++ b/index.php
@@ -118,10 +118,6 @@
</div>
EOF;
-// Write out common header
-$meta_image_path = $MYSITE . 'images/meta-image.png';
-$meta_description = "PHP is a popular general-purpose scripting language that powers
everything from your blog to the most popular websites in the world.";
-
site_header("Hypertext Preprocessor",
[
'current' => 'home',
@@ -149,25 +145,6 @@
],
'css' => ['home.css'],
'intro' => $intro,
- 'meta_tags' => <<<META
-<meta name="Description" content="{$meta_description}" />
-
-<meta name="twitter:card" content="summary_large_image" />
-<meta name="twitter:site" content="@official_php" />
-<meta name="twitter:title" content="PHP: Hypertext Preprocessor" />
-<meta name="twitter:description" content="{$meta_description}" />
-<meta name="twitter:creator" content="@official_php" />
-<meta name="twitter:image:src" content="{$meta_image_path}" />
-
-<meta itemprop="name" content="PHP: Hypertext Preprocessor" />
-<meta itemprop="description" content="$meta_description" />
-<meta itemprop="image" content="{$meta_image_path}" />
-
-<meta property="og:image" content="{$meta_image_path}" />
-<meta property="og:description" content="$meta_description" />
-
-<link href="https://fosstodon.org/@php"
rel="me" />
-META
],
);