[web-php] php-85-focus: Apply suggestions from code review

Author: Sergey Panteleev (saundefined) Date: 2025-10-12T20:48:04+03:00 Commit: https://github.com/php/web-php/commit/9d16f51ebc137e03acc4789ee4f13e37e97a54b7 Raw diff: https://github.com/php/web-php/commit/9d16f51ebc137e03acc4789ee4f13e37e97a54b7.diff Apply suggestions from code review Co-authored-by: Tim Düsterhus <tim@bastelstu.be> Changed paths: M releases/8.5/languages/en.php M releases/8.5/release.inc Diff: diff --git a/releases/8.5/languages/en.php b/releases/8.5/languages/en.php index a0c2f2e947..8f6e9b747e 100644 --- a/releases/8.5/languages/en.php +++ b/releases/8.5/languages/en.php @@ -7,14 +7,15 @@ 'main_subtitle' => 'PHP 8.5 is a major update of the PHP language.<br class="display-none-md"> It contains many new features, such as the new URI extension, support for modifying properties while cloning, the Pipe operator, performance improvements, bug fixes, and general cleanup.', 'upgrade_now' => 'Upgrade to PHP 8.5 now!', - 'pipe_operator_title' => 'Pipe operator', - 'url_parsing_api_title' => 'Add RFC 3986 and WHATWG URL compliant API', - 'url_parsing_api_description' => '<code>Uri\UriException</code>, <code>Uri\InvalidUriException</code>, <code>Uri\UriComparisonMode</code>, - <code>Uri\Rfc3986\Uri</code>, <code>Uri\WhatWg\InvalidUrlException</code>, <code>Uri\WhatWg\UrlValidationErrorType</code>, <code>Uri\WhatWg\UrlValidationError</code>, and <code>Uri\WhatWg\Url</code> are now available.', - 'clone_with_title' => 'Clone with v2', - 'no_discard_title' => 'New <code>#[\NoDiscard]</code> Attribute', - 'fcc_in_const_expr_title' => 'First Class Callables in constant expressions', - 'curl_share_persistence_improvement_title' => 'Persistent cURL share handle improvement', + 'pipe_operator_title' => 'Pipe Operator', + 'url_parsing_api_title' => 'New URI Extension', + 'url_parsing_api_description' => '<p>As an always-available part of PHP\'s standard library the new URI extension provides APIs to parse and modify URIs and URLs according to the RFC 3986 and the WHATWG URL standards.</p><p>The secure and standards-compliant URI parsing is powered by the <a href="https://uriparser.github.io/">uriparser</a> (RFC 3986) and <a href="https://lexbor.com/">Lexbor</a> (WHATWG URL) libraries.</p>', + 'clone_with_title' => 'Clone With', + 'clone_with_description' => 'It is not possible to update properties during object cloning by passing an associative array with the updated to the <code>clone()</code> function. This enables straight-forward support of the "with-er" pattern for <code>readonly</code> classes.', + 'no_discard_title' => '<code>#[\NoDiscard]</code> Attribute', + 'no_discard_description' => '<p>By adding the <code>#[\NoDiscard]</code> attribute to a function, PHP will check whether the returned value is consumed and emit a warning if it is not. This allows to improve the safety of APIs where the returned value is important, but where it is easy to forget using the return value by accident.</p><p>The associated <code>(void)</code> cast can be used to indicate that a value is intentionally unused.</p>', + 'fcc_in_const_expr_title' => 'Closures and First Class Callables in Constant Expressions', + 'curl_share_persistence_improvement_title' => 'Persistent cURL Share Handles', 'array_first_last_title' => 'New <code>array_first()</code> and <code>array_last()</code> functions', 'new_classes_title' => 'New Classes, Interfaces, and Functions', diff --git a/releases/8.5/release.inc b/releases/8.5/release.inc index e491fa612a..f9bf446651 100644 --- a/releases/8.5/release.inc +++ b/releases/8.5/release.inc @@ -150,6 +150,9 @@ PHP </div> </div> </div> + <div class="php8-compare__content"> + <?= message('clone_with_description', $lang) ?> + </div> </div> <div class="php8-compare"> @@ -244,6 +247,9 @@ PHP </div> </div> </div> + <div class="php8-compare__content"> + <?= message('no_discard_description', $lang) ?> + </div> </div> <div class="php8-compare">