cvs: phpweb /include manual-lookup.inc
| From: | Philip Olson | Date: | Thu, 09 Apr 2009 19:46:05 +0000 |
| Subject: | cvs: phpweb /include manual-lookup.inc | ||
| Groups: | php.webmaster | ||
| Request: | Send a blank email to php-webmaster+get-4368@lists.php.net to get a copy of this message | ||
philip Thu Apr 9 19:46:05 2009 UTC
Modified files:
/phpweb/include manual-lookup.inc
Log:
- Removed metaphone from search, too many false positives
- Removed mysqli hack, this was fixed in gen-phpweb-sqlite-db.php
- This closes several bugs including #47658 and #44713
http://cvs.php.net/viewvc.cgi/phpweb/include/manual-lookup.inc?r1=1.37&r2=1.38&diff_format=u
Index: phpweb/include/manual-lookup.inc
diff -u phpweb/include/manual-lookup.inc:1.37 phpweb/include/manual-lookup.inc:1.38
--- phpweb/include/manual-lookup.inc:1.37 Thu Apr 9 17:36:12 2009
+++ phpweb/include/manual-lookup.inc Thu Apr 9 19:46:05 2009
@@ -1,6 +1,6 @@
<?php // -*- C++ -*-
-// $Id: manual-lookup.inc,v 1.37 2009/04/09 17:36:12 philip Exp $
+// $Id: manual-lookup.inc,v 1.38 2009/04/09 19:46:05 philip Exp $
// We need this for error reporting
include_once $_SERVER['DOCUMENT_ROOT'] . '/include/errors.inc';
@@ -57,11 +57,6 @@
// Remove .. for security reasons
$keyword = str_replace("..", "", $keyword);
-
- // FIXME: Temporary hack for mysqli_ functions
- if (strpos($keyword, "mysqli_") === 0) {
- $keyword[6] = ".";
- }
// Try to find a manual page with the specified prefix
foreach ($sections as $section) {
@@ -133,12 +128,15 @@
} else {
// List a few variations, plus a metaphone version
+ // FIXME: metaphone causes too many false positives, disable for now
+ // the similar_text() search fallback works fine (see quickref.php)
+ // if this change remains, adjust the gen-phpweb-sqlite script accordingly
$keywords = array_unique(array(
$keyword,
str_replace(' ', '', $keyword),
str_replace(' ', '-', $keyword),
str_replace('-', '', $keyword),
- metaphone($keyword)
+ // metaphone($keyword)
));
// List of all the keywords in single quotes