#49924 [Opn]: The PHP documentation system needs to be able to render screenshots better

ID: 49924 Updated by: rquadling@php.net Reported By: ruslany at microsoft dot com Status: Open -Bug Type: Doc Build problem +Bug Type: Website problem Operating System: Irrelevant PHP Version: Irrelevant New Comment: As the css used by PhD is the site's css file this is really a website issue. Any chance that a phd.css file could be created which allows the phodoc team style the manual without impacting on the main css files? Either way, the following patch does the trick of removing the border and background colouring, but keeps the margin. Index: php/trunk/styles/site.css =================================================================== --- php/trunk/styles/site.css (revision 289798) +++ php/trunk/styles/site.css (working copy) @@ -879,7 +879,6 @@ div.example div.example-contents, table .phpcode, -div.mediaobject, div.classsynopsis, div.informalexample pre, div.informalexample .phpcode { @@ -887,6 +886,11 @@ margin: 10px; border: 1px outset #000; } + +div.mediaobject { + margin: 10px; +} + div.example-contents pre { background-color: #e1e1e1; } Previous Comments: ------------------------------------------------------------------------ [2009-10-20 14:34:43] rquadling@php.net The CSS responsible for this is in div.mediaobject from site.css line 880 ish. Index: site.css =================================================================== --- site.css (revision 289798) +++ site.css (working copy) @@ -879,7 +879,6 @@ div.example div.example-contents, table .phpcode, -div.mediaobject, div.classsynopsis, div.informalexample pre, div.informalexample .phpcode { @@ -887,6 +886,11 @@ margin: 10px; border: 1px outset #000; } + +div.mediaobject { + margin: 10px; +} + div.example-contents pre { background-color: #e1e1e1; } would remove the background and border but keep the margin. ------------------------------------------------------------------------ [2009-10-19 17:00:09] ruslany at microsoft dot com Description: ------------ Currently, when I use the <mediaobject> element to insert a screenshot, it gets rendered inside of a gray box, which is wider than the actual screenshot. Because of that the screenshot does not look good as it gets blended with the background. You can see the examples here: http://docs.php.net/manual/en/install.windows.iis7.php The PhD should support better rendering of the images and should not surround them with the gray background. As was suggested by Hannes, this could be controlled by the attibute on the <example> element, e.g. role="screenshot". Reproduce code: --------------- <mediaobject> <imageobject> <imagedata fileref="path to file" /> </imageobject> </mediaobject> Expected result: ---------------- There should not be gray background for the screenshots. Actual result: -------------- http://docs.php.net/manual/en/install.windows.iis7.php. See the gray backgrounds around screenshots. ------------------------------------------------------------------------ -- Edit this bug report at http://bugs.php.net/?id=49924&edit=1