Re: svn: /web/php/trunk/include/ footer.inc header.inc shared-manual.inc

On Mon, Dec 27, 2010 at 12:11 PM, Hannes Magnusson <bjori@php.net> wrote: > On Mon, Dec 27, 2010 at 13:10, Paul Dragoonis <dragoonis@gmail.com> wrote: >> On Mon, Dec 27, 2010 at 12:04 PM, Hannes Magnusson <bjori@php.net> wrote: >>> On Mon, Dec 27, 2010 at 12:49, Paul Dragoonis <dragoonis@gmail.com> wrote: >>>> On Mon, Dec 27, 2010 at 9:27 AM, Hannes Magnusson <bjori@php.net> wrote: >>>>> bjori                                    Mon, 27 Dec 2010 >>>>> 09:27:31 +0000 >>>>> >>>>> Revision: >>>>> http://svn.php.net/viewvc?view=revision&revision=306730 >>>>> >>>>> Log: >>>>> Always wrap the content in a layout-content section (caught by dragoonis) >>>>> >>>>> Changed paths: >>>>>    U   web/php/trunk/include/footer.inc >>>>>    U   web/php/trunk/include/header.inc >>>>>    U   web/php/trunk/include/shared-manual.inc >>>>> >>>>> Modified: web/php/trunk/include/footer.inc >>>>> =================================================================== >>>>> --- web/php/trunk/include/footer.inc    2010-12-27 09:06:31 UTC (rev 306729) >>>>> +++ web/php/trunk/include/footer.inc    2010-12-27 09:27:31 UTC (rev 306730) >>>>> @@ -1,4 +1,4 @@ >>>>> -         <div class="cleaner">&nbsp;</div> >>>>> +</section><!-- layout-content --> >>>>> >>>>>          <div id="footer"> >>>>>           <ul class="footmenu copyright"> >>>>> >>>>> Modified: web/php/trunk/include/header.inc >>>>> =================================================================== >>>>> --- web/php/trunk/include/header.inc    2010-12-27 09:06:31 UTC (rev 306729) >>>>> +++ web/php/trunk/include/header.inc    2010-12-27 09:27:31 UTC (rev 306730) >>>>> @@ -140,4 +140,5 @@ >>>>>     echo "</ul></aside>\n"; >>>>>  } >>>>>  ?> >>>>> +<section class="layout-content"> >>>>> >>>>> >>>>> Modified: web/php/trunk/include/shared-manual.inc >>>>> =================================================================== >>>>> --- web/php/trunk/include/shared-manual.inc     2010-12-27 09:06:31 UTC (rev >>>>> 306729) >>>>> +++ web/php/trunk/include/shared-manual.inc     2010-12-27 09:27:31 UTC (rev >>>>> 306730) >>>>> @@ -531,8 +531,6 @@ >>>>> >>>>>     $_SERVER["BASE_PAGE"] = "/manual/" . >>>>> $setup["head"][1] . "/" . $setup["this"][0]; >>>>>     site_header($setup["this"][1] . " - Manual ", >>>>> array("current" => "docs", "leftmenu" => $menu)); >>>>> - >>>>> -    echo '<div class="layout-content">'; >>>>>  } >>>>> >>>>>  function manual_header_beta(){} >>>>> @@ -540,8 +538,6 @@ >>>>> >>>>>     manual_notes(); >>>>>     echo "<br />"; >>>>> - >>>>> -    echo '</div>'; // layout-content >>>>>     site_footer(); >>>>>  } >>>>> >>>>> >>>>> >>>>> -- >>>>> PHP Webmaster List Mailing List (http://www.php.net/) >>>>> To unsubscribe, visit: >>>>> http://www.php.net/unsub.php >>>>> >>>> >>>> >>>> Hey Hannes, >>>> your changes are slightly conflicting with mine, re: the discussion we >>>> had earlier on MSN regarding the layout-container <div>. >>>> >>>> The problem was that on the templates with as /releases /logos >>>> /urlhowto  there was no containing wrapper for the content. >>>> This made it impossible to create a leftmenu, however after discussion >>>> we moved the leftbar aside to the top-right of the content area. >>>> This actually looks really good and fits the layout well. It also >>>> means the content can start from the far-left side of the page. >>>> >>>> The problem now is that, with the leftbar area on the top-right as a >>>> tips area, the wrapping layout-content is giving the content a >>>> margin-left that's no longer needed since #leftbar is actually on the >>>> topright. >>> >>> >>> We have a lot of space to play with. Minor padding on the left and >>> right are imo quite alread. >>> Its really annoying reading 5 paragraphs in one line, tightly squeezed >>> towards the edges of the browser window.. >>> >>> -Hannes >>> >> >> The left padding is there to put in the #leftbar, but that's not >> longer there since it's on the top-right (still needs comitted, i sent >> over the .diff) so we need one or the other. > > Or add right padding too? > > -Hannes > here it is.. checked other page-types and looks good. (attached)

Attachment: [text/x-patch] styles-tipsbox.diff