Re: Re: Subject: Wont create data in my tables

Oops - Hi Morten - yes I didn't mean for you to use the code as is, but just the lines which make the SQL statement : In fact it will be empty before you submit the form, because you have wrapped the SQL inside an "if" statement. Move the mysql_query inside the if { } as well, and it should work. BTW - I couldn't see where you are setting the variable $submit, so it may never work if that is not set to a value (or true). Cheers, Neil Smith. At 18:37 20/04/2003 +0200, you wrote:

Hi Neil If i use your code i get "Query was empty", but i made sure i filled out every form on my page with text so the query shouldn't be empty right ?. I have a little idea that it could be the "}" sign that is making this error, but not sure. I'm stuck right now and got no clue how to get out of this mess. I hope you got more ideas how to solve this problem. Regards Morten <?php include("dbconnect.php"); ?> <?php if ($submit =="Sign!") { $query = "insert into guestbook (

         name,
         location,
         email,
         url,
         comments
         )

values ('".$name."', '

         ".$location."', '
         ".$email."', '
         ".$url."', '
         ".$comments."
         ')";

} mysql_query($query) or die (mysql_error()) ?> ----- Original Message ----- From: "Neil Smith" <neil@fresh-toast.uklinux.net> To: <php-windows@lists.php.net> Cc: <fantomcat@hotmail.com> Sent: Sunday, April 20, 2003 12:22 AM Subject: [PHP-WIN] Re: Subject: Wont create data in my tables Hi Morten - no , the code is not correct. That is, because PHP handles variables within quotes differently for double quotes ( " ) where it replaces with the *actual value* of the variable, and within single quotes ( ' ) where it doesn't touch the value inside the quotes (it assumes you mean literally, the string '$name') The way to construct the SQL is like this instead : $query = "insert into guestbook (

         name,
         location,
         email,
         url,
         comments
         )

values ('".$name."', '

         ".$location."', '
         ".$email."', '
         ".$url."', '
         ".$comments."
         ')";

Hope that's clear (You can happily tab down like that in real PHP code too, to make the SQL more readable. Main thing is just to make sure you match the quotes on each end : I usually *print* the SQL until I'm sure I have the statement correct. HTH Neil Smith. At 20:43 19/04/2003 +0000, you wrote:

From: "Morten Nielsen" <fantomcat@hotmail.com> To: <php-windows@lists.php.net> Date: Sat, 19 Apr 2003 13:27:43 +0200 MIME-Version: 1.0 Content-Type: multipart/alternative;

        boundary="----=_NextPart_000_0109_01C30677.7590E1D0"

Message-ID: <BAY1-DAV30arcR4ZDgC00000dbd@hotmail.com> Subject: Wont create data in my tables. Can anybody tell me if this code is correct or not ?. <?php if ($submit =="Sign!") { $query = "insert into guestbook (name,location,email,url,comments) values ('$name', '$location', '$email', '$url', '$comments')"; mysql_query($query) or die (mysql_error()) ?>

-- PHP Windows Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php