Re: import_node patch

Hi mmh, couldn't resist ;) Eric, can you please check the patch at http://trash.chregu.tv/import_node.patch and see if that works for you (xmlDocCopyNode is definitively the better solution, as it does much more stuff, than we did in imported_node (copying namespaces and entities for example)) chregu On Tue, 11 Mar 2003, Christian Stocker wrote: > Hi eric > > I'll check your patch later this day > > > Here is a patch to import_node in domxml. I don't know where else to > > send it since mail to the original author didn't get a response. Perhaps > > someone can inform me of the correct place to send it. > > > > This patch does two things: > > > > (1) renames imported_node to import_node to follow the DOM function > > naming. > > i'll make an alias out of it. I don't want to remove functions in stable > releases... > > > (2) makes sure that the (new) owner document is set properly for all > > descendants in the imported subtree, instead of just the node itself. > > very good. I think, noone else used imported_node before (strange name > anyway...) > > - Some Issues: > > - It's maybe better to use xmlDocCopyNode than xmlCopyNode. Didn't look > into the code about the differences... > > - Check for not allowed Node types > > I can check this stuff, if you don't know enough about it, but this will > take some time (as i'm busy..). If you can do it and send me the patch > it will get integrated much faster ;) > > chregu > > > -- nam...christian stocker adr...pflanzschulstr. 31, ch-8004 zurich pho...+41 43 317 9984 www...http://blog.bitflux.ch mob...+41 76 561 8860 ema...chregu@phant.ch wor...+41 1 240 5670 gpg...0x5CE1DECB