Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2 / zend_compile.c zend_compile.h zend_globals.h zend_highlight.c zend_language_parser.y
zend_language_scanner.l

At 22:35 19.03.2003, Andi Gutmans wrote:

Argh. I thought we were still debating if this should be in the engine or not? I'd first like to understand all of the things you are planning to add because I don't want to bloat the engine and mess up the code too much. The question is if this is the last or the first patch in this round. Let's talk first, Andi

As far as i understood it this are the only things needed to change in the engine and andrei did it effective since he moved all post-processing to an upcoming extension. However i dislike the format: a trailing space after "/**" will bring us some bug reports because simply noone will understand the necessaty of that space and if you're editing code and do not start your coment after the /** your editor simply may remove that space and bang. The only reason to have this is to differentiate between normal comments and doc-comments but a normal comment is either '/' '*' '*' '*'+ .* '*' '/' (three '*' after '/') or only one '*' after the '/'. In other words when making use of doc-comments you know that you must not use '/**' elsewhere. A question: Could we rfor performance reasons emove estrndup/efree or is it really required? marcus

At 09:17 PM 3/19/2003 +0000, Andrei Zmievski wrote:

andrei          Wed Mar 19 16:17:47 2003 EDT

Modified files:

    /ZendEngine2        zend_compile.c zend_compile.h zend_globals.h
                        zend_highlight.c zend_language_parser.y
                        zend_language_scanner.l

Log: - Keep track of starting/ending line numbers for user functions. - Store last parsed doc comment in a compiler global for future use. [...]