Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2 / zend_language_scanner.l

Hello Derick, Friday, June 11, 2004, 9:22:05 AM, you wrote: > On Fri, 11 Jun 2004, Andi Gutmans wrote: >> Marcus, >> >> Are you sure we need to make this change at this point in the release >> cycle? I'm not really against this patch, but I wouldn't consider the >> previous state a "bug". Actually strictness might have it's advantages as >> it forces a very strict layout which will be easier to interpret by doc tools. > Right, that's why I didn't like this patch either. Well, there is simply no format at all between '/**' and '*/'. The only reason i changed from forcing '/**' being followed by a newline to being followed by a whitespace is that Derick required '/**' '*'* '*/' not being a doc comment (i could live with that). But many people like me are using doc comments that start like '/** @' (and also many people document everything the code and therefore i like properties accepting doc comments as well). That said i have to restate my original idea to prevent '/**' '*'* '*/' from becoming a doc comment was the following lexer line: <ST_IN_SCRIPTING>"/**"[^*] { To make that clear i even see the current solution as a bug for exactly the reason stated by Andi but slightly differently interpreted. I don't want to prevent any way people might use javadoc compatible tools. There simply is no format at all. In reality we should consider allowing '///' , '/*!' and '//!' as doc comment start to make it fully compatible with all javadoc tools (the first is standard javadoc and the other are doxygen specific). -- Best regards, Marcus mailto:helly@php.net