Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2 / zend_execute_API.c
| From: | Antony Dovgal | Date: | Fri, 23 Jul 2004 06:49:27 +0000 |
| Subject: | Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2 / zend_execute_API.c | ||
| References: | 1 2 3 4 5 6 7 8 9 10 | Groups: | php.zend-engine.cvs |
| Request: | Send a blank email to php-zend-engine-cvs+get-2795@lists.php.net to get a copy of this message | ||
On Thu, 22 Jul 2004 08:19:32 -0700
Andi Gutmans <andi@zend.com> wrote:
> hi Tony,
>
> Have you tried using valgrind with this?
> It would be great if you could track this down.
Nah, valgrind says nothing about it.
But it seems Marcus found a solution of the 1st problem:
--
<helly> change line 1352 to: EX(Ts) = (temp_variable *)
safe_emalloc(sizeof(temp_variable), op_array->T, 1);
--
and mod_files.c's warning seems to get finally fixed with this patch:
Index: mod_files.c
===================================================================
RCS file: /repository/php-src/ext/session/mod_files.c,v
retrieving revision 1.95
diff -u -r1.95 mod_files.c
--- mod_files.c 29 Mar 2004 21:44:07 -0000 1.95
+++ mod_files.c 23 Jul 2004 06:45:31 -0000
@@ -320,7 +320,7 @@
return FAILURE;
data->st_size = *vallen = sbuf.st_size;
- *val = emalloc(sbuf.st_size);
+ *val = emalloc(sbuf.st_size + 1);
#if defined(HAVE_PREAD)
n = pread(data->fd, *val, sbuf.st_size, 0);
---
WBR,
Antony Dovgal aka tony2001
tony2001@phpclub.net || antony@dovgal.com