Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2 / zend_API.c
| From: | Kamesh Jayachandran | Date: | Wed, 22 Sep 2004 14:26:39 +0000 |
| Subject: | Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2 / zend_API.c | ||
| References: | 1 2 | Groups: | php.zend-engine.cvs |
| Request: | Send a blank email to php-zend-engine-cvs+get-3006@lists.php.net to get a copy of this message | ||
Hi Derick,
I was applying the NetWare patches from hyanantha's acccount.
I will take care of the alignment of #ifdef.
With regards
Kamesh Jayachandran
On Wed, 22 Sep 2004 15:51:26 +0200 (CEST), "Derick Rethans"
<derick@php.net> said:
> On Wed, 22 Sep 2004, Anantha Kesari H Y wrote:
>
> > hyanantha Wed Sep 22 09:29:09 2004 EDT
> >
> > Modified files:
> > /ZendEngine2 zend_API.c
> > Log:
> > When Apache is unloaded, it calls dlclose on all the PHP extensions
> > that are loaded in memory. In the case of Apache 1.3, this call is blocking
> > indefinitely. As a work around, this call is bypassed for Apache 1.3 build on NetWare only. This
> > means that none of the loaded PHP extensions are unloaded. They will have to be manually unloaded
> > before re-loading the Apache 1.3 again.
>
> >
> > #if HAVE_LIBDL
> > + #ifdef NETWARE
> > + #ifdef APACHE_2_BUILD
> > if (module->handle) {
> > dlclose(module->handle);
> > }
> > + #endif
> > + #else
> > + if (module->handle) {
> > + dlclose(module->handle);
> > + }
> > + #endif
> > #endif
> > }
>
> The # in ifdefs need to start in column 1 or each line, otherwise it
> will break on some compilers. Please also adhere to our coding
> standards.
>
> Derick
>
> --
> Zend Engine CVS Mailing List (http://cvs.php.net/)
> To unsubscribe, visit: http://www.php.net/unsub.php
>