Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2 / zend.h
| From: | Marcus Boerger | Date: | Wed, 12 Oct 2005 20:16:10 +0000 |
| Subject: | Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2 / zend.h | ||
| References: | 1 2 | Groups: | php.zend-engine.cvs |
| Request: | Send a blank email to php-zend-engine-cvs+get-4239@lists.php.net to get a copy of this message | ||
Hello Dmitry,
they both have unicode support, the difference is that one returns a
natve string and the other a unicode string.
and no, you cannot move the code to the engine because it is based on
apache code.
regards
marcus
Wednesday, October 12, 2005, 9:17:08 AM, you wrote:
> Hi Marcus,
> Thank you for clarification.
> It is not a problem for me to switch to vspprintf() and revert my patch.
> But may be it is better to move PHP's printf() code to ZE.
> Also now PHP has snprintf.c and spprintf.c.
> First one hasn't unicode support and second has.
> Why?
> Thanks. Dmitry.
>> -----Original Message-----
>> From: Marcus Boerger [mailto:helly@php.net]
>> Sent: Wednesday, October 12, 2005 10:18 AM
>> To: Dmitry Stogov
>> Cc: 'Dmitry Stogov'; zend-engine-cvs@lists.php.net
>> Subject: Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2 / zend.h
>>
>>
>> Hello Dmitry,
>>
>> inside extensions you shall be using one of:
>> PHPAPI int spprintf( char **pbuf, size_t max_len, const char
>> *format, ...); PHPAPI int vspprintf(char **pbuf, size_t
>> max_len, const char *format, va_list ap); PHPAPI int
>> uspprintf( char **pbuf, size_t max_len, const char *format,
>> ...); PHPAPI int vuspprintf(char **pbuf, size_t max_len,
>> const char *format, va_list ap);
>>
>> Actually that pointer is using the same.
>>
>> marcus
>>
>> Wednesday, October 12, 2005, 7:49:06 AM, you wrote:
>>
>> > Hi Marcus,
>>
>> > Ext/soap redefines zend_error_cb() and need this function to format
>> > error message with new unicode-specific elements (%R, %v, ...).
>>
>> > Thanks. Dmitry.
>>
>> >> -----Original Message-----
>> >> From: Marcus Boerger [mailto:helly@php.net]
>> >> Sent: Tuesday, October 11, 2005 10:14 PM
>> >> To: Dmitry Stogov
>> >> Cc: zend-engine-cvs@lists.php.net
>> >> Subject: Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2 / zend.h
>> >>
>> >>
>> >> Hello Dmitry,
>> >>
>> >> why are you exporting this function pointer? If anything
>> >> then the engine is using this pointer outside the engine
>> >> itself the error is in using it.
>> >>
>> >> regards
>> >> marcus
>> >>
>> >> Tuesday, October 11, 2005, 1:39:02 PM, you wrote:
>> >>
>> >> > dmitry Tue Oct 11 07:39:02 2005 EDT
>> >>
>> >> > Modified files:
>> >> > /ZendEngine2 zend.h
>> >> > Log:
>> >> > Fixed compilation on Windows
>> >> >
>> >> >
>> >> >
>> >>
>>
>> http://cvs.php.net/diff.php/ZendEngine2/zend.h?r1=1.300&r2=1.301&ty=u
>> >> > Index: ZendEngine2/zend.h
>> >> > diff -u ZendEngine2/zend.h:1.300 ZendEngine2/zend.h:1.301
>> >> > --- ZendEngine2/zend.h:1.300 Tue Sep 27 03:58:59 2005
>> >> > +++ ZendEngine2/zend.h Tue Oct 11 07:39:01 2005
>> >> > @@ -17,7 +17,7 @@
>> >> >
>> >> >
>> >> +-------------------------------------------------------------
>> >> ---------+
>> >> > */
>> >> >
>> >> > -/* $Id: zend.h,v 1.300 2005/09/27 07:58:59 dmitry Exp $ */
>> >> > +/* $Id: zend.h,v 1.301 2005/10/11 11:39:01 dmitry Exp $ */
>> >> >
>> >> > #ifndef ZEND_H
>> >> > #define ZEND_H
>> >> > @@ -544,7 +544,7 @@
>> >> > extern ZEND_API void (*zend_error_cb)(int type, const char
>> >> > *error_filename, const uint error_lineno, const char
>> >> *format, va_list
>> >> > args); extern void (*zend_on_timeout)(int seconds
>> >> TSRMLS_DC); extern
>> >> > ZEND_API int (*zend_stream_open_function)(const char *filename,
>> >> > zend_file_handle *handle TSRMLS_DC); -extern int
>> >> > (*zend_vspprintf)(char **pbuf, size_t max_len, const char
>> >> *format, va_list ap);
>> >> > +extern ZEND_API int (*zend_vspprintf)(char **pbuf,
>> size_t max_len,
>> >> > +const char *format, va_list ap);
>> >> > extern ZEND_API char *(*zend_getenv)(char *name, size_t name_len
>> >> > TSRMLS_DC);