Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2(PHP_5_1) / zend_API.c

Hello Dmitry, you need to update the test. Basically i just added the static test guarded by a flag. The rest is more or less cosmetics and speed improvement and fixing consequences. regards marcus Friday, November 4, 2005, 8:09:46 AM, you wrote: > PHP5 allows call non-static methods as static (It just emits strict > warning). > So is_callable() should allow them too. > I see you fixed it, but don't understand how it was done. > "ext/sqlite/tests/sqlite_oo_030.phpt" still fail. > Thanks. Dmitry. >> -----Original Message----- >> From: Marcus Boerger [mailto:helly@php.net] >> Sent: Friday, November 04, 2005 3:01 AM >> To: Dmitry Stogov >> Cc: zend-engine-cvs@lists.php.net; Zeev Suraski; Ilia Alshanetsky >> Subject: Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2(PHP_5_1) / zend_API.c >> >> >> Hello Dmitry, >> >> Thursday, November 3, 2005, 1:01:18 PM, you wrote: >> >> > Hi Marcus, >> >> > This patch breaks some tests. >> >> > Zend/tests/bug32290.phpt >> >> This test is corrupt. It tries to use a non static function >> as a static function. What we want here is: >> -call_user_func_array(array("TestA","doSomething"), array($i)); >> +call_user_func_array(array($this, "TestA::doSomething"), array($i)); >> >> I have a patch for that which i will apply once 5.1.0 is out. >> Right now i fixed the static checks. >> >> > ext/sqlite/tests/sqlite_oo_030.phpt >> I fixed what was causing trouble here and as a consequence we >> are now detecting the error earlier so i also fixed the error. >> >> > ext/standard/tests/tests/general_functions/bug32647.phpt >> Fixed. >> >> Thanks for noticing. >> >> regards >> marcus >> >> Best regards, Marcus