Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2 /tests abstract-static.phpt object-null.phpt
| From: | Marcus Boerger | Date: | Sat, 13 May 2006 00:48:17 +0000 |
| Subject: | Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2 /tests abstract-static.phpt object-null.phpt | ||
| References: | 1 | Groups: | php.zend-engine.cvs |
| Request: | Send a blank email to php-zend-engine-cvs+get-4875@lists.php.net to get a copy of this message | ||
Hello Derick,
the test is wrong. We just added a missing check in 5.2. That means it
is a non severe error already in 5.0 and 5.1. Just nobody told us about
yet. So please just drop the test case or even better fix it with the
expected error message. If this is a real issue for you company we could
go with a compromise and make it an E_STRICT in 5.2 and drop the *not bug
but feature* in 5.3/6.0. Since E:STRICT was all about notifying ppl about
future changes, wasn't it?
best regards
marcus
Friday, May 12, 2006, 12:02:13 PM, you wrote:
> derick Fri May 12 10:02:13 2006 UTC
> Added files:
> /ZendEngine2/tests abstract-static.phpt object-null.phpt
> Log:
> - Added tests for BC breaking changes.
>
>
> 5ä5?uä/.8ò]K
> http://cvs.php.net/viewcvs.cgi/ZendEngine2/tests/abstract-static.phpt?view=markup&rev=1.1
> Index: ZendEngine2/tests/abstract-static.phpt
> +++ ZendEngine2/tests/abstract-static.phpt
> --TEST--
> Test for abstract static classes
> --FILE--
> <?php
> abstract class ezcDbHandler extends PDO
> {
> public function __construct( $dbParams, $dsn )
> {
> $user = null;
> $pass = null;
> $driverOptions = null;
> }
> abstract static public function getName();
> static public function hasFeature( $feature )
> {
> return false;
> }
> }
?>>
> DONE
> --EXPECT--
> DONE
>
> http://cvs.php.net/viewcvs.cgi/ZendEngine2/tests/object-null.phpt?view=markup&rev=1.1
> Index: ZendEngine2/tests/object-null.phpt
> +++ ZendEngine2/tests/object-null.phpt
> --TEST--
> Test whether an object is NULL or not.
> --FILE--
> <?php
> class Bla
> {
> }
> $b = new Bla;
> var_dump($b != null);
> var_dump($b == null);
> var_dump($b !== null);
> var_dump($b === null);
?>>
> --EXPECT--
> bool(true)
> bool(false)
> bool(true)
> bool(false)
Best regards,
Marcus