Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2 / zend_language_scanner.l
| From: | (Marcus Börger) | Date: | Thu, 28 Nov 2002 17:19:05 +0000 |
| Subject: | Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2 / zend_language_scanner.l | ||
| References: | 1 2 3 | Groups: | php.zend-engine.cvs |
| Request: | Send a blank email to php-zend-engine-cvs+get-665@lists.php.net to get a copy of this message | ||
At 18:13 28.11.2002, Jon Parise wrote:
On Thu, Nov 28, 2002 at 06:08:19PM +0100, Derick Rethans wrote:The point is that it seems we will have public, protected and private functionns. Using T_VAR as public token for methods is a little bit dirty. marcusIt would be better to return T_PUBLIC instead of T_VAR and handle T_PUBLIC in the parser since we want to have public,protected and private member functions. See patch is below:Why? It's exactly the same. Introducing new tokens which don't add anything doesn't look right to me. I agree with Derick here. As I understood things, "public" is basically just a convenience alias for "var". -- Jon Parise (jon@php.net) :: The PHP Project (http://www.php.net/)