Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2(PHP_5_3) / Zend.m4 zend.c zend_compile.c zend_globals.h zend_highlight.c zend_language_scanner.c
zend_language_scanner.h zend_language_scanner.l zend_language_scanner_defs.h zend_multibyte.h

Hello Marcus, > > The current test scipts are covering the most important > > feature of zend-multibyte support, > > > 1. test for flex incompatible encoding (0x5c issue) and 'declare' sentence > > multibye_encoding_001.phpt > > We don't have a test yet that switches encodings with multiple declare > statements or should that be disallowed? For each PHP script, a single script encoding should be defined using declare statement on the very first line of script. I think that this retriction is same as Unicode implementation of PHP 6.0. > > > 2. test for UTF-8 BOM > > multibye_encoding_002.phpt > > 3. test for UTF-16 BOM and UTF-16 encoded Unicode script > > multibye_encoding_003.phpt > > > The encoding conversion feature is also covered by these scripts. > > What kind of test scripts do you need ? > > Anything that brings code coverage for the multibyte stuff as high as > possible. I agree with you. Rui -- Rui Hirokawa <rui_hirokawa@ybb.ne.jp>