RE: [ZEND-ENGINE-CVS] cvs: ZendEngine2 / zend_API.c zend_API.h
| From: | Harald Radi | Date: | Tue, 04 Mar 2003 09:28:27 +0000 |
| Subject: | RE: [ZEND-ENGINE-CVS] cvs: ZendEngine2 / zend_API.c zend_API.h | ||
| References: | 1 | Groups: | php.zend-engine.cvs |
| Request: | Send a blank email to php-zend-engine-cvs+get-989@lists.php.net to get a copy of this message | ||
the text has been copied from zend_disable_function(), that's why it is like
it is. beside that i disagree '* has been disabled.' doesn't contain a reason
thus the user will get confused, doesn't know whom to contact, mails to
php-dev, files a bugreport, ... you know that.
personally i'd actually be even more verbose: "* has been disabled by your isp
for security reasons, don't bother us !".
regards,
Harald Radi
--
nme - we can heal you
http://www.nme.at
Ortner Radi Schwenk GnbR
Tumpenweg 528
5084 Grossgmain, Salzburg
Austria
> -----Original Message-----
> From: Jon Parise [mailto:jon@php.net]
> Sent: Tuesday, March 04, 2003 9:46 AM
> To: Harald Radi
> Cc: zend-engine-cvs@lists.php.net
> Subject: Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2 / zend_API.c
> zend_API.h
>
>
> On Mon, Mar 03, 2003 at 01:22:43AM -0000, Harald Radi wrote:
>
> > phanto Sun Mar 2 20:22:43 2003 EDT
> >
> > Modified files:
> > /ZendEngine2 zend_API.c zend_API.h
> > Log:
> > commiting zend_disable_class patch for George:
> > disabled classes will be replaced by dummy classes
> > that print a warning upon instanciation
>
> [...]
>
> > + zend_error(E_WARNING, "%s() has been disabled for
> security reasons", class_type->name);
>
> I propose removing the "for security reasons" part of that string.
> It's enough to just say that the class has been disabled. There's no
> need to presume the administrator's intentions for disabling it.
>
> --
> Jon Parise (jon@php.net) :: The PHP Project (http://www.php.net/)
>