Re: [SVN-MIGRATION] matched rows function for PDO

Amr Shahin wrote:

Hello i have added a matchedRows to PDO, and implemented it on the mysql driver i hope im doing this correctly since this is the first time im uploading a change to php u can find the patch files attached

Hi Amr, Thanks for contributing. It's great to see ideas coming in. Can I suggest a few things? - Include a description of the proposal. Write it for inclusion at http://wiki.php.net/rfc Discuss performance implications and any alternatives like SQL functions and a WHERE clause(?) - Include some testcases - Mail your proposal to internals@lists.php.net. The SVN list is for a source code control migration project - Do you diff in the other order, so new lines have a "+" prefix. - Be prepared to port the code to PHP 6 with appropriate character handling. Chris -- Email: christopher.jones@oracle.com Twitter: http://twitter.com/ghrd