Re: [SVN-MIGRATION] svn: SVNROOT/

On Tue, Jul 14, 2009 at 08:38, Hannes Magnusson<hannes.magnusson@gmail.com> wrote: > On Tue, Jul 14, 2009 at 01:40, Gwynne Raskind<gwynne@php.net> wrote: >> -    if ($username == $commit_user) { >> -        $from = imap_8bit("\"{$fullname}\" >> <{$username}@php.net>"); >> +    if ($username === 'ladderalice') { >> +        $saw_last_ISO = TRUE; >> +    } >> +    if ($username === $commit_user) { >> +        if (!$saw_last_ISO) { >> +            $fullname = iconv("ISO-8859-1", "UTF-8//TRANSLIT", >> $fullname); >> +        } >> +        $from = "\"{$fullname}\" <{$username}@php.net>"; >>         break; >>     } >>  } > > Huh? That makes no sense to me. > > You are probably looking for something along the lines of: > if (!mb_check_encoding($fullname, "UTF-8")) { >  $fullname = iconv("ISO-8859-1", "UTF-8", $fullname); > } And that seems to have broken commits from my gsoc student: From: =?utf-8?Q?"Moacir=20de=20Oliveira=20Miranda=20J=C3=BAnior"=20<moac?=.=?utf-8?Q?ir@php.net>?= Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 To: doc-cvs@lists.php.net, gwynne@php.net