Re: cvs: php-src /ext/filter logical_filters.c /ext/filter/tests 010.phpt 013.phpt 014.phpt 015.phpt 016.phpt 017.phpt 018.phpt 019.phpt 031.phpt
034.phpt bug8315.phpt filter_data.phpt

Hello Derick, On 10/11/06, Derick Rethans <derick@php.net> wrote:

derick          Wed Oct 11 14:48:33 2006 UTC

Modified files:

    /php-src/ext/filter logical_filters.c
    /php-src/ext/filter/tests   010.phpt 013.phpt 014.phpt 015.phpt
                                016.phpt 017.phpt 018.phpt 019.phpt
                                031.phpt 034.phpt bug8315.phpt
                                filter_data.phpt

Log: - Change validating filters to return "null" on failure so that they can be

    distinguised from the value "false" which might be valid as well.

Please revert this commit. This is not what we agreed on. We did agree on this behavior before (as far as I remember there is even a bug report about that) and it is again too late for such changes. Invalid values return FALSE. Value that does not exist return NULL (input_get(INPUT_GET, "doesnotexist",...); ) Boolean values set to FALSE return FALSE Doing so you can distinguish invalid values from non existent values. Boolean values are the only case where it is not possible to distinguish FALSE from invalid as they can be FALSE, but it is really not an issue. This is what we agreed on and is the best possible solution to what you tried to solve. We cannot break or change again the API behaviors and you can certainly not take such decisions unilaterally. If you do not revert it, we'll have to delay the RC6 (which is planed for tomorrow). --Pierre