Re: cvs: php-src /ext/filter logical_filters.c /ext/filter/tests 010.phpt 013.phpt 014.phpt 015.phpt 016.phpt 017.phpt 018.phpt 019.phpt 031.phpt
034.phpt bug8315.phpt filter_data.phpt

Derick, The (very valid) issue you were trying to address pertains to the fact that the latest API change resulted in a regression (we didn't have a test for it) which made non-found keys and invalid input both return FALSE, thus preventing identification of what precisely had happened. Looking at the old behavior it would seem that there was already schema established whereby non-found keys would return NULL and invalid values return FALSE. While it does cause slight confusion for the boolean filter, it does prevent an arguably more common problem relating to validation of checkbox fields, which do not get sent if left unselected. Given that there is already some prior development in this direction I think it would be best to restore that behavior. Ultimately, your concern was to allow for separation between the instance of invalid data and non-present data, which this change does permit. Here is a URL to a patch that does exactly that, hopefully you will find it agreeable. http://bb.prohost.org/patch/filter.txt Ilia