Re: new module - LZO
| From: | Wez Furlong | Date: | Sun, 21 Sep 2003 23:33:46 +0000 |
| Subject: | Re: new module - LZO | ||
| References: | 1 | Groups: | php.pecl.dev |
| Request: | Send a blank email to pecl-dev+get-26@lists.php.net to get a copy of this message | ||
Hi Marcin,
This sounds great :)
I haven't had a chance to look through your code yet but I will try to look
at it tomorrow.
Two things spring to mind:
1. lzo2a_999_compress() is a bit difficult to remember. It's more in the
PHP spirit to name the functions something like lzo_compress() and
lzo_decompress(). Keeping the same names as used in the library is
generally good practice though.
2. The LZO library is GPL.
That makes your code GPL too. The GPL can be a real headache for us and our
end users. I wonder if you could talk to the author and see if he will
allow lzo to be used with PHP under the terms of either the PHP (or another
non-viral opensource license)? Even with GPL status, you will still be able
to put your extension into PECL.
Apply for a PHP CVS account here:
http://www.php.net/cvs-php.php
and explain that you want access to pecl CVS so that you can commit your lzo
extension.
(I know there is a form on the pecl site, but that is under construction at
the moment)
Welcome to PECL :)
--Wez.
----- Original Message -----
From: "Marcin Gibu³a" <mg@iceni.pl>
To: <pecl-dev@lists.php.net>
Sent: Sunday, September 21, 2003 11:12 PM
Subject: [PECL-DEV] new module - LZO
> Hi,
> I wrote php module which is wrapper to LZO compression library.
> (http://www.oberhumer.com/opensource/lzo/).
>
> I would like to send it to PECL and pecl website tells me to anounce
myself on
> this list... so, you can download it from
http://www.iceni.pl/lzo-1.0.tar.gz
> (it requires a copy LZO library). No documentation so far - functions
names
> are the same as in LZO library, for example: lzo2a_999_compress,
> lzo2a_decompress, etc. There is over 40 functions implemented.
>
> Basic testing has been done. (linux/php-4.3.3)