Re: new module - LZO

On Monday 22 September 2003 01:33, Wez Furlong wrote: > Hi Marcin, > > This sounds great :) > I haven't had a chance to look through your code yet but I will try to look > at it tomorrow. This code is messy... but I'm going to clean in next few days. (all these #ifdefs ...) > 1. lzo2a_999_compress() is a bit difficult to remember. It's more in the > PHP spirit to name the functions something like lzo_compress() and > lzo_decompress(). Keeping the same names as used in the library is > generally good practice though. Right, but there is over 30 lzo_compress functions :) But you're right, i was thinking about something easier to remember, maybe lzo_compress(string data [, int algorithm) ... > 2. The LZO library is GPL. > That makes your code GPL too. The GPL can be a real headache for us and > our end users. I wonder if you could talk to the author and see if he will > allow lzo to be used with PHP under the terms of either the PHP (or another > non-viral opensource license)? Even with GPL status, you will still be > able to put your extension into PECL. Well, i'm not aware with all these licences, but I'll make the code GPL if it is necessary. -- mg