Re: YAML/Syck extension

Hi Alexey, On Fri, 2007-07-06 at 12:35 +0400, "Alexey Zakhlestin" wrote: > > Do you have some code to show already? > > http://code.whytheluckystiff.net/svn/syck/trunk/ext/php/ I just scrolled over the code without really reviewing it but a small note: In your PHP_FUNCTIONs you have code like if (ZEND_NUM_ARGS() != 1) { WRONG_PARAM_COUNT; } if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "s", &arg, &arg_len) == FAILURE) { return; } The first check isn't really needed since zend_parse_parameters gives a nice error message in case the parameter count is wrong and even gives a hint what number of arguments is required. > Do I really need to host source in PECL's CVS? > Currently it is hosted at WhyTheLuckyStiff's Subversion repo The benefit is that other PHP developers read the commit mails and might have hints about better use of the APIs and maybe even fix stuff the bad thing is that PHP developers might read your commits and change your code :-) johannes