Re: kadm5 patch to add keytab authentication

Hi Miles, On Fri, 2010-08-27 at 11:33 -0700, Miles Davis wrote: > Hi, > > I'm Miles Davis, and I work in the Computer Science department at > Stanford University. We've recently started using the kadm5 extension > to replace some scary old code, and my summer research students (CCd) > made some improvements that I'd like to submit, namely the ability to > obtain tickets via keytab rather than password. If the extension needs > a maintainer, I'm volunteering. I've added Holger, as maintainer, on CC. > http://cf.stanford.edu/kadm5-csdcf.patch > kadm5.c:79 inserted php function declaration for kadm5_init_with_skey > kadm5.c:491-550 inserted php function kadm5_init_with_skey which > mirrors kadm5_init_with_password, exchanging the password argument for > a keytab argument and wrapping "kadm5/admin.h" function > kadm5_init_with_password. Small comments: + if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "ssss", + &admin_server, &admin_server_len, + &realm, &realm_len, &princstr, &princstr_len, + &keytab, &keytab_len) == FAILURE) { + WRONG_PARAM_COUNT; + } in case of a problem zend_parse_parameters while spit out an error message. The WRONG_PARAMETER_COUNT macro will add another one. we usually do a simple "return;" + php_error(E_WARNING, "Internal error! handle == NULL!"); php_error_docref is what we're usually using. > config.m4:62 removing reference to libdyn, which no longer exists In what way is that system/library version specific? Maybe others need it? I don't know anything about kadm5 so I can't comment on the actual functionality :-) johannes