Re: [APC-DEV] 3.0.x vs. 3.1.x

I've been going through the .16 to .17 changes. I don't actually think the expunge callback stuff is the problem, but I can't seem to reproduce the problem people are seeing either. www.php.net seems to be running smoothly on 3.0.17. See http://www.php.net/~rasmus/apc.php So at this point I think the strategy should be to take the .16 code and only apply the bug fixes and the removal of the local cache stuff and push out a .18 based on that. It's 7am in Bangalore right now, so Gopal should be coming online in a couple of hours. He was playing with stuff last night, so let's see if he has found something. -Rasmus Brian Shire wrote:

On Mar 26, 2008, at 9:12 AM, Rasmus Lerdorf wrote:

It looks like we have a regression: http://pecl.php.net/bugs/bug.php?id=13505 The largest change from 3.0.16 was the expunge callback stuff. Gopal has new code for 3.1.0 that will make cache expunges much easier and this code will need to change completely. And since we don't actually use it in 3.0.x, I think we should just pull it from the 3.0 tree and see if that fixes the MediaWiki issue.

I have code in my working copy that will rely on this so I'll be curious what Gopal's new code for this looks like. (Mostly just need a way to easily configure the functionality of this and have it happen from the SMA level). Seeing of course as it's not used in 3.0.x, seems fine to me that we should remove it to see if it help these issues we're seeing, (or at least have someone test a revert patch out). Of course this means we'll need to re-implement your fix for the apc_add() bug that this also corrects. Are we pretty happy with the revert of PHP4 stuff, or do we think something may have snuck in there as well?

We should also fix: http://pecl.php.net/bugs/bug.php?id=13504

I just ran through the patch/code and it looks good to me. I can probably take a look at the above revert later tonight for my expunge callback and then apply this patch later once the regression fix is confirmed. (assuming that sounds good to everyone).

Probably means we need a 3.0.18 sometime soon. -Rasmus -- APC Development Mailing List (http://pecl.php.net/APC) To unsubscribe, visit: http://www.php.net/unsub.php